* [Qemu-trivial] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"
@ 2019-03-16 20:15 Philippe Mathieu-Daudé
2019-03-17 1:25 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-16 20:15 UTC (permalink / raw)
To: qemu-trivial, qemu-devel
Cc: qemu-ppc, David Gibson, Hervé Poussineau,
Philippe Mathieu-Daudé
In commit 47973a2dbf we split the last generic chipset out of
the PC board, but missed to remove the i8042 keyboard controller.
This omission was later fixed in commit 7cb00357c1, but here we
forgot to remove the "i8042.h" include. Do it now.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/ppc/prep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 847d320465..b7f459d475 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -40,7 +40,6 @@
#include "hw/ide.h"
#include "hw/loader.h"
#include "hw/timer/mc146818rtc.h"
-#include "hw/input/i8042.h"
#include "hw/isa/pc87312.h"
#include "hw/net/ne2000-isa.h"
#include "sysemu/arch_init.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"
2019-03-16 20:15 [Qemu-trivial] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" Philippe Mathieu-Daudé
@ 2019-03-17 1:25 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-03-17 1:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, qemu-devel, qemu-ppc, Hervé Poussineau
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
On Sat, Mar 16, 2019 at 09:15:28PM +0100, Philippe Mathieu-Daudé wrote:
> In commit 47973a2dbf we split the last generic chipset out of
> the PC board, but missed to remove the i8042 keyboard controller.
> This omission was later fixed in commit 7cb00357c1, but here we
> forgot to remove the "i8042.h" include. Do it now.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Applied to ppc-for-4.1.
> ---
> hw/ppc/prep.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 847d320465..b7f459d475 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -40,7 +40,6 @@
> #include "hw/ide.h"
> #include "hw/loader.h"
> #include "hw/timer/mc146818rtc.h"
> -#include "hw/input/i8042.h"
> #include "hw/isa/pc87312.h"
> #include "hw/net/ne2000-isa.h"
> #include "sysemu/arch_init.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-17 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-16 20:15 [Qemu-trivial] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" Philippe Mathieu-Daudé
2019-03-17 1:25 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).