From: Alex Williamson <alex.williamson@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: lvivier@redhat.com, qemu-devel@nongnu.org,
qemu-trivial@nongnu.org, liq3ea@gmail.com, philmd@redhat.com
Subject: Re: [Qemu-trivial] [PATCH 1/4] vfio: pci: make "vfio-pci-nohotplug" as MACRO
Date: Sat, 18 May 2019 08:18:30 -0600 [thread overview]
Message-ID: <20190518081830.5adab426@x1.home> (raw)
In-Reply-To: <20190518032811.60341-1-liq3ea@163.com>
On Fri, 17 May 2019 20:28:08 -0700
Li Qiang <liq3ea@163.com> wrote:
Why? (No commit message, nor cover letter)
> CC: qemu-trivial@nongnu.org
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> hw/vfio/pci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 8cecb53d5c..08729e5875 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -40,6 +40,8 @@
> #define TYPE_VFIO_PCI "vfio-pci"
> #define PCI_VFIO(obj) OBJECT_CHECK(VFIOPCIDevice, obj, TYPE_VFIO_PCI)
>
> +#define TYPE_VIFO_PCI_NOHOTPLUG "vfio-pci-nohotplug"
> +
> static void vfio_disable_interrupts(VFIOPCIDevice *vdev);
> static void vfio_mmap_set_enabled(VFIOPCIDevice *vdev, bool enabled);
>
> @@ -3304,8 +3306,8 @@ static void vfio_pci_nohotplug_dev_class_init(ObjectClass *klass, void *data)
> }
>
> static const TypeInfo vfio_pci_nohotplug_dev_info = {
> - .name = "vfio-pci-nohotplug",
> - .parent = "vfio-pci",
> + .name = TYPE_VIFO_PCI_NOHOTPLUG,
> + .parent = TYPE_VFIO_PCI,
> .instance_size = sizeof(VFIOPCIDevice),
> .class_init = vfio_pci_nohotplug_dev_class_init,
> };
next prev parent reply other threads:[~2019-05-18 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 3:28 [Qemu-trivial] [PATCH 1/4] vfio: pci: make "vfio-pci-nohotplug" as MACRO Li Qiang
2019-05-18 3:28 ` [Qemu-trivial] [PATCH 2/4] hw: vfio: drop TYPE_FOO MACRO in VMStateDescription Li Qiang
2019-05-18 14:20 ` Alex Williamson
2019-05-20 1:29 ` Li Qiang
2019-05-20 20:12 ` Alex Williamson
2019-05-18 3:28 ` [Qemu-trivial] [PATCH 3/4] vfio: platform: fix a typo Li Qiang
2019-05-18 14:20 ` Alex Williamson
2019-05-18 3:28 ` [Qemu-trivial] [PATCH 4/4] pci: msix: move 'MSIX_CAP_LENGTH' to header file Li Qiang
2019-05-18 14:21 ` Alex Williamson
2019-05-18 14:18 ` Alex Williamson [this message]
2019-05-20 1:27 ` [Qemu-trivial] [PATCH 1/4] vfio: pci: make "vfio-pci-nohotplug" as MACRO Li Qiang
2019-05-20 20:02 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518081830.5adab426@x1.home \
--to=alex.williamson@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=lvivier@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).