qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Tony Krowiak" <akrowiak@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Farhan Ali" <alifm@linux.ibm.com>,
	qemu-s390x@nongnu.org, "Eric Farman" <farman@linux.ibm.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	qemu-trivial@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Pierre Morel" <pmorel@linux.ibm.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: [Qemu-trivial] [PULL 2/9] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
Date: Wed, 22 May 2019 18:07:16 +0200	[thread overview]
Message-ID: <20190522160723.31484-3-laurent@vivier.eu> (raw)
In-Reply-To: <20190522160723.31484-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

In commit 1cab464136b4 we incorrectly described the
EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
options to the EDK2 build tools, but it only expands
the CFLAGS (not to the CPPFLAGS).
Update the description to be more accurate.

Reported-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190506141923.12183-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 roms/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/roms/Makefile b/roms/Makefile
index 0ce84a45ad57..ea6aec56abdd 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
 		$(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
 		$(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
 
-# Build scripts can pass compiler/linker flags to the EDK2 build tools
-# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
+# Build scripts can pass compiler/linker flags to the EDK2
+# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
 # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
 #
 # Example:
-- 
2.20.1



  parent reply	other threads:[~2019-05-22 16:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 16:07 [Qemu-trivial] [PULL 0/9] Trivial branch patches Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 1/9] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log Laurent Vivier
2019-05-22 16:07 ` Laurent Vivier [this message]
2019-05-22 16:07 ` [Qemu-trivial] [PULL 3/9] roms: List and describe the Makefile 'clean' rule Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 4/9] migration: Fix typo in migrate_add_blocker() error message Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 5/9] configure: Fix spelling of sdl-image in --help Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 6/9] vfio: pci: make "vfio-pci-nohotplug" as MACRO Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 7/9] hw: vfio: drop TYPE_FOO MACRO in VMStateDescription Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 8/9] vfio: platform: fix a typo Laurent Vivier
2019-05-22 16:07 ` [Qemu-trivial] [PULL 9/9] pci: msix: move 'MSIX_CAP_LENGTH' to header file Laurent Vivier
2019-05-23 11:56 ` [Qemu-trivial] [Qemu-devel] [PULL 0/9] Trivial branch patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522160723.31484-3-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=lersek@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=philmd@redhat.com \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).