* [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword
@ 2025-04-08 16:27 Zhao Liu
2025-04-08 16:49 ` Alex Bennée
2025-04-08 18:56 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Zhao Liu @ 2025-04-08 16:27 UTC (permalink / raw)
To: Daniel P . Berrangé; +Cc: qemu-devel, qemu-trivial, Zhao Liu
Fix the typo in the error message to help `grep` the example:
ERROR: New file '***' requires 'SPDX-License-Identifer'
Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6ae9d7febee8..365892de0428 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1688,11 +1688,11 @@ sub process {
/\.(c|h|py|pl|sh|json|inc|Makefile)$/) {
# source code files MUST have SPDX license declared
ERROR("New file '$expect_spdx_file' requires " .
- "'SPDX-License-Identifer'");
+ "'SPDX-License-Identifier'");
} else {
# Other files MAY have SPDX license if appropriate
WARN("Does new file '$expect_spdx_file' need " .
- "'SPDX-License-Identifer'?");
+ "'SPDX-License-Identifier'?");
}
}
$expect_spdx = 1;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword
2025-04-08 16:27 [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword Zhao Liu
@ 2025-04-08 16:49 ` Alex Bennée
2025-04-08 18:56 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2025-04-08 16:49 UTC (permalink / raw)
To: Zhao Liu; +Cc: Daniel P . Berrangé, qemu-devel, qemu-trivial
Zhao Liu <zhao1.liu@intel.com> writes:
> Fix the typo in the error message to help `grep` the example:
>
> ERROR: New file '***' requires 'SPDX-License-Identifer'
>
> Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword
2025-04-08 16:27 [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword Zhao Liu
2025-04-08 16:49 ` Alex Bennée
@ 2025-04-08 18:56 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-08 18:56 UTC (permalink / raw)
To: Zhao Liu, Daniel P . Berrangé; +Cc: qemu-devel, qemu-trivial
On 8/4/25 18:27, Zhao Liu wrote:
> Fix the typo in the error message to help `grep` the example:
>
> ERROR: New file '***' requires 'SPDX-License-Identifer'
>
> Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-08 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-08 16:27 [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword Zhao Liu
2025-04-08 16:49 ` Alex Bennée
2025-04-08 18:56 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).