* [PATCH trivial v2] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported
@ 2025-08-05 18:17 Michael Tokarev
2025-08-05 18:50 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2025-08-05 18:17 UTC (permalink / raw)
To: qemu-devel, qemu-block, Eric Blake, Kevin Wolf
Cc: Michael Tokarev, Philippe Mathieu-Daudé, qemu-trivial
This test uses cache.direct=true, but does not check if O_DIRECT
is supported by the underlying filesystem, and fails, for example,
on a tmpfs (which is rather common on various auto-builders, in CI,
etc).
Fix this by using `_supported_cache_modes none directsync`.
Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches"
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
v2: use `_supported_cache_modes none directsync` instead of _require_o_direct
as suggested by Philippe.
tests/qemu-iotests/tests/mirror-sparse | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/tests/mirror-sparse b/tests/qemu-iotests/tests/mirror-sparse
index cfcaa600ab..3b183eea88 100755
--- a/tests/qemu-iotests/tests/mirror-sparse
+++ b/tests/qemu-iotests/tests/mirror-sparse
@@ -40,6 +40,7 @@ cd ..
_supported_fmt qcow2 raw # Format of the source. dst is always raw file
_supported_proto file
_supported_os Linux
+_supported_cache_modes none directsync
_require_disk_usage
echo
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH trivial v2] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported
2025-08-05 18:17 [PATCH trivial v2] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported Michael Tokarev
@ 2025-08-05 18:50 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2025-08-05 18:50 UTC (permalink / raw)
To: Michael Tokarev
Cc: qemu-devel, qemu-block, Eric Blake, Kevin Wolf,
Philippe Mathieu-Daudé, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Tue, Aug 05, 2025 at 09:17:30PM +0300, Michael Tokarev wrote:
> This test uses cache.direct=true, but does not check if O_DIRECT
> is supported by the underlying filesystem, and fails, for example,
> on a tmpfs (which is rather common on various auto-builders, in CI,
> etc).
>
> Fix this by using `_supported_cache_modes none directsync`.
>
> Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches"
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> v2: use `_supported_cache_modes none directsync` instead of _require_o_direct
> as suggested by Philippe.
>
> tests/qemu-iotests/tests/mirror-sparse | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-05 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-05 18:17 [PATCH trivial v2] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported Michael Tokarev
2025-08-05 18:50 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).