From: Evgeny Kolmakov <randomjack94dev@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, maciej.szmigiero@oracle.com,
Evgeny Kolmakov <randomjack94dev@gmail.com>
Subject: [PATCH] hw/hyperv/vmbus: Use QEMU_LOCK_GUARD()
Date: Thu, 9 Jul 2026 23:27:22 +0300 [thread overview]
Message-ID: <20260709202722.7291-1-randomjack94dev@gmail.com> (raw)
Replace manual qemu_mutex_(un)lock() calls with
QEMU_LOCK_GUARD() to remove 'goto out' code
Signed-off-by: Evgeny Kolmakov <randomjack94dev@gmail.com>
---
hw/hyperv/vmbus.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
index c5259d1a76..ab99f082d1 100644
--- a/hw/hyperv/vmbus.c
+++ b/hw/hyperv/vmbus.c
@@ -1525,14 +1525,12 @@ static VMBusChannel *find_channel(VMBus *vmbus, uint32_t id)
static int enqueue_incoming_message(VMBus *vmbus,
const struct hyperv_post_message_input *msg)
{
- int ret = 0;
uint8_t idx, prev_size;
- qemu_mutex_lock(&vmbus->rx_queue_lock);
+ QEMU_LOCK_GUARD(&vmbus->rx_queue_lock);
if (vmbus->rx_queue_size == HV_MSG_QUEUE_LEN) {
- ret = -ENOBUFS;
- goto out;
+ return -ENOBUFS;
}
prev_size = vmbus->rx_queue_size;
@@ -1544,9 +1542,7 @@ static int enqueue_incoming_message(VMBus *vmbus,
if (!prev_size) {
vmbus_resched(vmbus);
}
-out:
- qemu_mutex_unlock(&vmbus->rx_queue_lock);
- return ret;
+ return 0;
}
static uint16_t vmbus_recv_message(const struct hyperv_post_message_input *msg,
@@ -2097,10 +2093,10 @@ static void process_message(VMBus *vmbus)
void *msgdata;
uint32_t msglen;
- qemu_mutex_lock(&vmbus->rx_queue_lock);
+ QEMU_LOCK_GUARD(&vmbus->rx_queue_lock);
if (!vmbus->rx_queue_size) {
- goto unlock;
+ return;
}
hv_msg = &vmbus->rx_queue[vmbus->rx_queue_head];
@@ -2149,8 +2145,6 @@ out:
vmbus->rx_queue_head %= HV_MSG_QUEUE_LEN;
vmbus_resched(vmbus);
-unlock:
- qemu_mutex_unlock(&vmbus->rx_queue_lock);
}
static const struct {
--
2.43.0
next reply other threads:[~2026-07-09 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 20:27 Evgeny Kolmakov [this message]
2026-07-17 17:51 ` [PATCH] hw/hyperv/vmbus: Use QEMU_LOCK_GUARD() Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709202722.7291-1-randomjack94dev@gmail.com \
--to=randomjack94dev@gmail.com \
--cc=maciej.szmigiero@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox