* Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64
[not found] ` <9403a3d0-41f6-add2-04fd-12034fe7699a@redhat.com>
@ 2017-06-29 16:52 ` Stefan Weil
2017-06-29 17:02 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2017-06-29 16:52 UTC (permalink / raw)
To: Eric Blake, Philippe Mathieu-Daudé, qemu-devel,
Paolo Bonzini, Richard Henderson, Alex Bennée,
Emilio G . Cota, QEMU Trivial
Am 29.06.2017 um 18:29 schrieb Eric Blake:
> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>> remove some copy/paste leftover, code seems sane.
>>
>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Double-sob seems odd.
Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).
>
>> ---
>> tcg/tci.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Note from the author: it's not a copy/paste leftover, but was
there on purpose: that code part was simply never executed
before, and I only removed the TODO() statements from tested
code.
So you are the first one who found a test case. Congratulations.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64
2017-06-29 16:52 ` [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64 Stefan Weil
@ 2017-06-29 17:02 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-06-29 17:02 UTC (permalink / raw)
To: Stefan Weil, Eric Blake, qemu-devel, Paolo Bonzini,
Richard Henderson, Alex Bennée, Emilio G . Cota,
QEMU Trivial
On 06/29/2017 01:52 PM, Stefan Weil wrote:
> Am 29.06.2017 um 18:29 schrieb Eric Blake:
>> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>>> remove some copy/paste leftover, code seems sane.
>>>
>>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Double-sob seems odd.
>
> Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).
>
>>
>>> ---
>>> tcg/tci.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>
>> Otherwise,
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>
> Note from the author: it's not a copy/paste leftover, but was
> there on purpose: that code part was simply never executed
> before, and I only removed the TODO() statements from tested
> code.
I'll reword the commit message in my tci-fixes-for-2.10-v2 series.
> So you are the first one who found a test case. Congratulations.
Oh nice :)
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
Thank.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170629010300.2848-1-f4bug@amsat.org>
[not found] ` <20170629010300.2848-6-f4bug@amsat.org>
[not found] ` <9403a3d0-41f6-add2-04fd-12034fe7699a@redhat.com>
2017-06-29 16:52 ` [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64 Stefan Weil
2017-06-29 17:02 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).