From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fT7xF-0001VM-AZ for mharc-qemu-trivial@gnu.org; Wed, 13 Jun 2018 11:45:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT7x7-0001Qx-QH for qemu-trivial@nongnu.org; Wed, 13 Jun 2018 11:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT7x6-0001jx-PB for qemu-trivial@nongnu.org; Wed, 13 Jun 2018 11:44:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60956 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT7x2-0001Wz-Cw; Wed, 13 Jun 2018 11:44:48 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC29A818F022; Wed, 13 Jun 2018 15:44:47 +0000 (UTC) Received: from [10.36.116.24] (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9EC52166BB2; Wed, 13 Jun 2018 15:44:45 +0000 (UTC) To: =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= Cc: Stefan Hajnoczi , zhang.zhanghailiang@huawei.com, Ben Warren , qemu-trivial@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , Eduardo Habkost References: <1528866321-23886-1-git-send-email-thuth@redhat.com> <1528866321-23886-5-git-send-email-thuth@redhat.com> <20180613133840.GK24528@stefanha-x1.localdomain> <20180613134452.GU19901@redhat.com> <20180613151942.GC19901@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Message-ID: <2a2631c6-3af9-237d-6040-ba4d2e42d7ad@redhat.com> Date: Wed, 13 Jun 2018 17:44:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180613151942.GC19901@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 13 Jun 2018 15:44:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 13 Jun 2018 15:44:47 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 15:45:00 -0000 On 13.06.2018 17:19, Daniel P. Berrang=C3=A9 wrote: > On Wed, Jun 13, 2018 at 05:11:51PM +0200, Thomas Huth wrote: >> On 13.06.2018 15:44, Daniel P. Berrang=C3=A9 wrote: >>> On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: >>>> On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: >>>>> We've got three ways of enabling an accelerator: -machine accel=3Dx= yz, >>>>> -accel xyz and -enable-xyz. For new QEMU users, this must be very >>>>> confusing ("Which one do I have to use? Is there a difference betwe= en >>>>> the options?"). While -enable-kvm was useful in the past, there is = no >>>>> real good reason for using it anymore today ("-accel kvm" is even l= ess >>>>> to type than "-enable-kvm"), so let's decrease the confusing amount= of >>>>> options in our documenation a little bit by removing the -enable-xy= z >>>>> here. Note that the option itself is neither removed nor marked as >>>>> deprecated - since -enable-kvm is likely used in a lot of scripts a= nd >>>>> since its code is easy to maintain, we should keep it around to avo= id >>>>> to break old setups. >>>>> >>>>> Signed-off-by: Thomas Huth >>>>> --- >>>>> PS: I guess Paolo won't like this patch ... let's try it anyway ;-= ) >>>> >>>> It's widely used and we're removing the documentation for it?! That= is >>>> likely to cause issues for new users who refer to the man page to >>>> understand the QEMU command-lines they see online, in scripts, etc. >>> >>> Agreed, this is a very bad idea. Any option that is accepted by QEMU, >>> but not documented is a bug that must be fixed. IOW removing docs >>> is creating bugs. >> >> Not documenting unliked options that are still kept for compatibility >> was at least a common practice in the past (see -no-kvm for example, o= r >> many of those deprecated options like -net channel that have been >> removed in the past year). >=20 > If we're planning to deprecate & then delete an option, then I > don't mind if docs are dropped, but IIUC, in this case we're > not doing that - the option will essentially exist forever. >=20 >>> If we want to help users understand why we have -enable-kvm, just >>> make the docs say that it is syntactic for '-machine accel=3Dkvm'. >>> Users can decide for themselves whether they want to switch to >>> the more verbose way or not >> >> Uh, well, in this case "-enable-kvm" is already the more verbose way: >> "-accel kvm" is shorter :-) >=20 > If I'm a user looking for how to enable KVM, then -enable-kvm is the > one I'll pick because of the obvious name. Hmm, maybe we should also add -configure-network-backend, --configure-character-device-backend and -setup-block-backend as synonyms for -netdev, -chardev and -blockdev, just because they have a more obvious name? ;-) Thomas