From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cTlFw-0005n6-E6 for mharc-qemu-trivial@gnu.org; Wed, 18 Jan 2017 03:06:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTlFt-0005l3-SH for qemu-trivial@nongnu.org; Wed, 18 Jan 2017 03:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTlFs-000680-Uh for qemu-trivial@nongnu.org; Wed, 18 Jan 2017 03:06:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39402) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTlFo-00063u-Hk; Wed, 18 Jan 2017 03:06:00 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 891F3C04B936; Wed, 18 Jan 2017 08:06:00 +0000 (UTC) Received: from [10.36.116.60] (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0I85vR8025834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Jan 2017 03:05:58 -0500 To: Ziyue Yang , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <1484726609-16537-1-git-send-email-skiver.cloud.yzy@gmail.com> Cc: Fam Zheng , Paolo Bonzini , Ziyue Yang From: Thomas Huth Message-ID: <30fd6a54-e9c9-a6e4-8f94-b02db91cae71@redhat.com> Date: Wed, 18 Jan 2017 09:05:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484726609-16537-1-git-send-email-skiver.cloud.yzy@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 18 Jan 2017 08:06:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 08:06:06 -0000 On 18.01.2017 09:03, Ziyue Yang wrote: > From: Ziyue Yang > > Some updates from fprintf(stderr, ...) to error_report. > > Signed-off-by: Ziyue Yang > --- > gdbstub.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 426d55e..959f6dc 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu, > *p = s; > if (g_pos) { > if (g_pos != s->base_reg) { > - fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n" > - "Expected %d got %d\n", xml, g_pos, s->base_reg); > + error_report("Error: Bad gdb register numbering for '%s', " > + "expected %d got %d", xml, g_pos, s->base_reg); > } else { > cpu->gdb_num_g_regs = cpu->gdb_num_regs; > } > @@ -890,7 +890,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) > } > case 'k': > /* Kill the target */ > - fprintf(stderr, "\nQEMU: Terminated via GDBstub\n"); > + error_report("QEMU: Terminated via GDBstub"); > exit(0); > case 'D': > /* Detach packet */ > @@ -1358,8 +1358,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va) > break; > default: > bad_format: > - fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n", > - fmt - 1); > + error_report("gdbstub: Bad syscall format string '%s'", > + fmt - 1); > break; > } > } else { > -- > 2.7.4 Reviewed-by: Thomas Huth