From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: david@redhat.com, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] tcg: remove softfloat from --disable-tcg builds
Date: Wed, 23 May 2018 06:34:16 +0200 [thread overview]
Message-ID: <3a90789d-ca98-9305-a2d4-2b6d166a6d2d@redhat.com> (raw)
In-Reply-To: <20180522192034.13318-1-pbonzini@redhat.com>
On 22.05.2018 21:20, Paolo Bonzini wrote:
> Even though the presence of softfloat does not cause --disable-tcg builds to fail,
> it is the single largest .o file in them. Remove it, since TCG is the only client.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Makefile.target | 2 +-
> hw/i386/x86-iommu-stub.c | 132 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 133 insertions(+), 1 deletion(-)
> create mode 100644 hw/i386/x86-iommu-stub.c
>
> diff --git a/Makefile.target b/Makefile.target
> index d0ec77a307..dad2cf8778 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -97,7 +97,7 @@ obj-$(CONFIG_TCG) += tcg/tcg.o tcg/tcg-op.o tcg/tcg-op-vec.o tcg/tcg-op-gvec.o
> obj-$(CONFIG_TCG) += tcg/tcg-common.o tcg/optimize.o
> obj-$(CONFIG_TCG_INTERPRETER) += tcg/tci.o
> obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o
> -obj-y += fpu/softfloat.o
> +obj-$(CONFIG_TCG) += fpu/softfloat.o
> obj-y += target/$(TARGET_BASE_ARCH)/
> obj-y += disas.o
> obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
Without that x86-iommu-stub.c file:
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2018-05-23 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:20 [Qemu-trivial] [PATCH] tcg: remove softfloat from --disable-tcg builds Paolo Bonzini
2018-05-22 19:26 ` [Qemu-trivial] [Qemu-devel] " no-reply
2018-05-22 19:27 ` Peter Maydell
2018-05-22 22:07 ` Paolo Bonzini
2018-05-22 20:53 ` Richard Henderson
2018-05-22 22:06 ` Paolo Bonzini
2018-05-23 4:34 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a90789d-ca98-9305-a2d4-2b6d166a6d2d@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).