From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field
Date: Fri, 6 Dec 2024 17:10:30 +0100 [thread overview]
Message-ID: <3d48414f-903b-4b15-b85d-c2edc5ffb9b3@redhat.com> (raw)
In-Reply-To: <20241127122812.89487-1-philmd@linaro.org>
On 27/11/2024 13.28, Philippe Mathieu-Daudé wrote:
> Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
> flag") remove the last use of XHCINecState::flags but neglected
> to remove it; do that now.
>
> Reported-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/usb/hcd-xhci-nec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c
> index 0c063b3697d..1a191fc7372 100644
> --- a/hw/usb/hcd-xhci-nec.c
> +++ b/hw/usb/hcd-xhci-nec.c
> @@ -30,10 +30,8 @@
> OBJECT_DECLARE_SIMPLE_TYPE(XHCINecState, NEC_XHCI)
>
> struct XHCINecState {
> - /*< private >*/
> XHCIPciState parent_obj;
> - /*< public >*/
> - uint32_t flags;
> +
> uint32_t intrs;
> uint32_t slots;
> };
> @@ -51,7 +49,6 @@ static void nec_xhci_instance_init(Object *obj)
> XHCIPciState *pci = XHCI_PCI(obj);
> XHCINecState *nec = NEC_XHCI(obj);
>
> - pci->xhci.flags = nec->flags;
> pci->xhci.numintrs = nec->intrs;
> pci->xhci.numslots = nec->slots;
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
parent reply other threads:[~2024-12-06 16:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241127122812.89487-1-philmd@linaro.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d48414f-903b-4b15-b85d-c2edc5ffb9b3@redhat.com \
--to=thuth@redhat.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).