qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c
Date: Fri, 29 Jul 2011 09:38:05 -0500	[thread overview]
Message-ID: <4E32C5CD.9070001@us.ibm.com> (raw)
In-Reply-To: <1311690791.7898.6.camel@d941e-10>

On 07/26/2011 09:33 AM, Stefan Berger wrote:
> This patch fixes a compilation error in xen-mapcache.c .
>
> /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’:
> /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Stefan Berger<stefanb@linux.vnet.ibm.com>

Applied.  Thanks.

Regards,

Anthony Liguori

>
> ---
>   xen-mapcache.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: qemu-git/xen-mapcache.c
> ===================================================================
> --- qemu-git.orig/xen-mapcache.c
> +++ qemu-git/xen-mapcache.c
> @@ -237,7 +237,7 @@ uint8_t *xen_map_cache(target_phys_addr_
>
>   ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
>   {
> -    MapCacheEntry *entry = NULL, *pentry = NULL;
> +    MapCacheEntry *entry = NULL;
>       MapCacheRev *reventry;
>       target_phys_addr_t paddr_index;
>       target_phys_addr_t size;
> @@ -263,7 +263,6 @@ ram_addr_t xen_ram_addr_from_mapcache(vo
>
>       entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];
>       while (entry&&  (entry->paddr_index != paddr_index || entry->size != size)) {
> -        pentry = entry;
>           entry = entry->next;
>       }
>       if (!entry) {
>
>
>



      parent reply	other threads:[~2011-07-29 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 14:33 [Qemu-trivial] [PATCH] Fix a compilation error in xen-mapcache.c Stefan Berger
2011-07-26 14:38 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2011-07-26 14:45   ` Stefan Berger
2011-07-29 14:38 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E32C5CD.9070001@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).