From: Mark Wu <wudxw@linux.vnet.ibm.com>
To: Li Zhi Hui <zhihuili@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak
Date: Fri, 02 Dec 2011 15:28:41 +0800 [thread overview]
Message-ID: <4ED87E29.1010207@linux.vnet.ibm.com> (raw)
In-Reply-To: <1322796863-3475-1-git-send-email-zhihuili@linux.vnet.ibm.com>
On 12/02/2011 11:34 AM, Li Zhi Hui wrote:
> Signed-off-by: Li Zhi Hui<zhihuili@linux.vnet.ibm.com>
> ---
> qemu-nbd.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 291cba2..ab7fa6c 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -500,8 +500,10 @@ int main(int argc, char **argv)
> sharing_fds[0] = tcp_socket_incoming(bindto, port);
> }
>
> - if (sharing_fds[0] == -1)
> + if (sharing_fds[0] == -1) {
> + g_free(sharing_fds);
> return 1;
> + }
>
> if (device) {
> int ret;
Zhihui,
Kernel should free all memory used by the process after it exits. So
there's no memory leak even without explicit free.
next prev parent reply other threads:[~2011-12-02 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 3:34 [Qemu-trivial] [PATCH] qemu-nbd.c : fix memory leak Li Zhi Hui
2011-12-02 7:28 ` Mark Wu [this message]
2011-12-02 7:42 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-12-02 7:48 ` [Qemu-trivial] " Paolo Bonzini
2011-12-02 11:08 ` [Qemu-trivial] [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED87E29.1010207@linux.vnet.ibm.com \
--to=wudxw@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=zhihuili@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).