From: "Andreas Färber" <afaerber@suse.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: alexey.korolev@endace.com, qemu-trivial@nongnu.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code
Date: Wed, 21 Mar 2012 13:35:12 +0100 [thread overview]
Message-ID: <4F69CB00.10002@suse.de> (raw)
In-Reply-To: <m3r4wmm93l.fsf@blackfin.pond.sub.org>
Am 21.03.2012 13:28, schrieb Markus Armbruster:
> Alexey Korolev <alexey.korolev@endace.com> writes:
>
>>> Hi,
>>>
>>> There is a typo in i440FX init code. This is causing problems when
>>> somebody wants to access 64bit PCI range.
>>>
>>>
>>> Signed-off-by: Alexey Korolev <alexey.korolev@endace.com>
>>> ---
>>>
>>> hw/piix_pci.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>>> index 3ed3d90..aab8188 100644
>>> --- a/hw/piix_pci.c
>>> +++ b/hw/piix_pci.c
>>> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn,
>>> b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, pic,
>>> address_space_mem, address_space_io, ram_size,
>>> pci_hole_start, pci_hole_size,
>>> - pci_hole64_size, pci_hole64_size,
>>> + pci_hole64_start, pci_hole64_size,
>>> pci_memory, ram_memory);
>>> return b;
>>> }
>>>
>>>
>>>
>> Hi there,
>>
>> Any chance that someone could have a look and commit this?
>
> Stefan, would you like to take this through your trivial queue?
Not without fixing up the commit message, please. CC'ing mst since this
is a PCI issue and not some random unmaintained area of code.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-03-21 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1330479314.29508.7.camel@nzhmlwks0057.ad.endace.com>
[not found] ` <1332307597.20383.2.camel@nzhmlwks0057.ad.endace.com>
2012-03-21 12:28 ` [Qemu-trivial] [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code Markus Armbruster
2012-03-21 12:35 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69CB00.10002@suse.de \
--to=afaerber@suse.de \
--cc=alexey.korolev@endace.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).