Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

[Markus Armbruster]

Alexey Korolev <alexey.korolev@endace.com> writes:

>> Hi,
>> 
>> There is a typo in i440FX init code. This is causing problems when
>> somebody wants to access 64bit PCI range.
>> 
>> 
>> Signed-off-by: Alexey Korolev <alexey.korolev@endace.com>
>> ---
>> 
>>  hw/piix_pci.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>> index 3ed3d90..aab8188 100644
>> --- a/hw/piix_pci.c
>> +++ b/hw/piix_pci.c
>> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn,
>>      b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, pic,
>>                             address_space_mem, address_space_io, ram_size,
>>                             pci_hole_start, pci_hole_size,
>> -                           pci_hole64_size, pci_hole64_size,
>> +                           pci_hole64_start, pci_hole64_size,
>>                             pci_memory, ram_memory);
>>      return b;
>>  }
>> 
>> 
>> 
> Hi there,
>
> Any chance that someone could have a look and commit this?

Stefan, would you like to take this through your trivial queue?

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

[Andreas Färber]

Am 21.03.2012 13:28, schrieb Markus Armbruster:
> Alexey Korolev <alexey.korolev@endace.com> writes:
> 
>>> Hi,
>>>
>>> There is a typo in i440FX init code. This is causing problems when
>>> somebody wants to access 64bit PCI range.
>>>
>>>
>>> Signed-off-by: Alexey Korolev <alexey.korolev@endace.com>
>>> ---
>>>
>>>  hw/piix_pci.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>>> index 3ed3d90..aab8188 100644
>>> --- a/hw/piix_pci.c
>>> +++ b/hw/piix_pci.c
>>> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn,
>>>      b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, pic,
>>>                             address_space_mem, address_space_io, ram_size,
>>>                             pci_hole_start, pci_hole_size,
>>> -                           pci_hole64_size, pci_hole64_size,
>>> +                           pci_hole64_start, pci_hole64_size,
>>>                             pci_memory, ram_memory);
>>>      return b;
>>>  }
>>>
>>>
>>>
>> Hi there,
>>
>> Any chance that someone could have a look and commit this?
> 
> Stefan, would you like to take this through your trivial queue?

Not without fixing up the commit message, please. CC'ing mst since this
is a PCI issue and not some random unmaintained area of code.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg