From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Move balloon.o, numa.o and bootdevice.o to common-obj-y
Date: Wed, 14 Jun 2017 13:18:21 +0200 [thread overview]
Message-ID: <4b0ebafd-46da-3ec9-7a43-c008ba90b32b@redhat.com> (raw)
In-Reply-To: <1496931482-29914-1-git-send-email-thuth@redhat.com>
On 08.06.2017 16:18, Thomas Huth wrote:
> There does not seem to be any target specific code in these files, so
> we can put them into "common-obj" instead of "obj" to compile them only
> once for all targets.
Self-NACK: balloon.c uses kvm_enabled() which in turn depends on
CONFIG_KVM ... and that flag is target-specific, so balloon.o can not be
moved to common-obj right now.
We should poison CONFIG_KVM for common code ... I'll have a look into
that...
Thomas
next prev parent reply other threads:[~2017-06-14 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 14:18 [Qemu-trivial] [PATCH] Makefile: Move balloon.o, numa.o and bootdevice.o to common-obj-y Thomas Huth
2017-06-08 14:37 ` Juan Quintela
2017-06-14 11:18 ` Thomas Huth [this message]
2017-06-14 11:25 ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2017-06-16 11:03 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b0ebafd-46da-3ec9-7a43-c008ba90b32b@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).