From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SwZmp-0000FN-BE for mharc-qemu-trivial@gnu.org; Wed, 01 Aug 2012 10:20:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZmi-0008KX-4R for qemu-trivial@nongnu.org; Wed, 01 Aug 2012 10:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwZme-0001iA-3c for qemu-trivial@nongnu.org; Wed, 01 Aug 2012 10:20:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZmU-0001hD-1f; Wed, 01 Aug 2012 10:20:10 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q71EK8gw023175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Aug 2012 10:20:08 -0400 Received: from balrog.usersys.tlv.redhat.com (dhcp-4-121.tlv.redhat.com [10.35.4.121]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q71EK360031087; Wed, 1 Aug 2012 10:20:04 -0400 Message-ID: <50193B12.5000006@redhat.com> Date: Wed, 01 Aug 2012 17:20:02 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Peter Maydell References: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> <5019379B.5080206@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [PATCH] exec.c: Remove out of date comment X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2012 14:20:30 -0000 On 08/01/2012 05:17 PM, Peter Maydell wrote: > On 1 August 2012 15:05, Avi Kivity wrote: >> On 08/01/2012 04:35 PM, Peter Maydell wrote: >>> Remove an out of date comment: this comment used to be attached to >>> cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally >>> inserted a couple of other functions between the comment and its function. >>> It is in any case obsolete since (a) the function arguments it refers >>> to have been replaced with a single MemoryRegionSection* argument and >>> (b) the inability to handle regions whose offset_within_address_space >>> and offset_within_region aren't equally aligned was fixed as part of >>> the rewrite of this code. >> >> (c) it doesn't use the conventional block comment style. > > I agree that I don't like the aesthetics of this style of comment > but we don't actually mandate a One True Comment Format in HACKING > so I usually try to suppress my preferences in code review :-) Indeed comment style is quite low on the patch rejection scale, which is why I didn't ask for a preliminary patch that fixes the comment style before deleting it in the second one (giving us the option to backport the first patch to qemu 1.1.stable if we get user complaints). -- error compiling committee.c: too many arguments to function