qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Anthony Liguori" <aliguori@us.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] xhci: fix bad print specifier
Date: Fri, 22 Feb 2013 06:40:21 +0100	[thread overview]
Message-ID: <512704C5.1010706@weilnetz.de> (raw)
In-Reply-To: <1361483888-8976-1-git-send-email-hpoussin@reactos.org>

Am 21.02.2013 22:58, schrieb Hervé Poussineau:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/usb/hcd-xhci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 5796102..07afdee 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1152,8 +1152,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
>  
>      if (sctx->sct == -1) {
>          xhci_dma_read_u32s(epctx->xhci, sctx->pctx, ctx, sizeof(ctx));
> -        fprintf(stderr, "%s: init sctx #%d @ %lx: %08x %08x\n", __func__,
> -                streamid, sctx->pctx, ctx[0], ctx[1]);
> +        fprintf(stderr, "%s: init sctx #%d @ " DMA_ADDR_FMT ": %08x %08x\n",
> +                __func__, streamid, sctx->pctx, ctx[0], ctx[1]);
>          sct = (ctx[0] >> 1) & 0x07;
>          if (epctx->lsa && sct != 1) {
>              *cc_error = CC_INVALID_STREAM_TYPE_ERROR;


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Anthony, this is a build regression in git master, so we should not
wait for qemu-trivial to apply it.

Thanks,

Stefan



  reply	other threads:[~2013-02-22  5:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 21:58 [Qemu-trivial] [PATCH] xhci: fix bad print specifier Hervé Poussineau
2013-02-22  5:40 ` Stefan Weil [this message]
2013-02-22 11:26 ` Gerd Hoffmann
2013-02-23 16:49 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512704C5.1010706@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=hpoussin@reactos.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).