* [Qemu-trivial] [PATCH] xhci: fix bad print specifier
@ 2013-02-21 21:58 Hervé Poussineau
2013-02-22 5:40 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hervé Poussineau @ 2013-02-21 21:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Hervé Poussineau, Gerd Hoffmann
This fixes the following compilation error:
hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
‘long long unsigned int’, but argument 4 has type ‘unsigned int’
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/usb/hcd-xhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 5796102..07afdee 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1152,8 +1152,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
if (sctx->sct == -1) {
xhci_dma_read_u32s(epctx->xhci, sctx->pctx, ctx, sizeof(ctx));
- fprintf(stderr, "%s: init sctx #%d @ %lx: %08x %08x\n", __func__,
- streamid, sctx->pctx, ctx[0], ctx[1]);
+ fprintf(stderr, "%s: init sctx #%d @ " DMA_ADDR_FMT ": %08x %08x\n",
+ __func__, streamid, sctx->pctx, ctx[0], ctx[1]);
sct = (ctx[0] >> 1) & 0x07;
if (epctx->lsa && sct != 1) {
*cc_error = CC_INVALID_STREAM_TYPE_ERROR;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] xhci: fix bad print specifier
2013-02-21 21:58 [Qemu-trivial] [PATCH] xhci: fix bad print specifier Hervé Poussineau
@ 2013-02-22 5:40 ` Stefan Weil
2013-02-22 11:26 ` [Qemu-trivial] " Gerd Hoffmann
2013-02-23 16:49 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2013-02-22 5:40 UTC (permalink / raw)
To: Hervé Poussineau, Anthony Liguori
Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
Am 21.02.2013 22:58, schrieb Hervé Poussineau:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/usb/hcd-xhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 5796102..07afdee 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1152,8 +1152,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
>
> if (sctx->sct == -1) {
> xhci_dma_read_u32s(epctx->xhci, sctx->pctx, ctx, sizeof(ctx));
> - fprintf(stderr, "%s: init sctx #%d @ %lx: %08x %08x\n", __func__,
> - streamid, sctx->pctx, ctx[0], ctx[1]);
> + fprintf(stderr, "%s: init sctx #%d @ " DMA_ADDR_FMT ": %08x %08x\n",
> + __func__, streamid, sctx->pctx, ctx[0], ctx[1]);
> sct = (ctx[0] >> 1) & 0x07;
> if (epctx->lsa && sct != 1) {
> *cc_error = CC_INVALID_STREAM_TYPE_ERROR;
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Anthony, this is a build regression in git master, so we should not
wait for qemu-trivial to apply it.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] xhci: fix bad print specifier
2013-02-21 21:58 [Qemu-trivial] [PATCH] xhci: fix bad print specifier Hervé Poussineau
2013-02-22 5:40 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
@ 2013-02-22 11:26 ` Gerd Hoffmann
2013-02-23 16:49 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2013-02-22 11:26 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-trivial, qemu-devel
On 02/21/13 22:58, Hervé Poussineau wrote:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] xhci: fix bad print specifier
2013-02-21 21:58 [Qemu-trivial] [PATCH] xhci: fix bad print specifier Hervé Poussineau
2013-02-22 5:40 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2013-02-22 11:26 ` [Qemu-trivial] " Gerd Hoffmann
@ 2013-02-23 16:49 ` Blue Swirl
2 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2013-02-23 16:49 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
Thanks, applied.
On Thu, Feb 21, 2013 at 9:58 PM, Hervé Poussineau <hpoussin@reactos.org> wrote:
> This fixes the following compilation error:
> hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
> ‘long long unsigned int’, but argument 4 has type ‘unsigned int’
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/usb/hcd-xhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 5796102..07afdee 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1152,8 +1152,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
>
> if (sctx->sct == -1) {
> xhci_dma_read_u32s(epctx->xhci, sctx->pctx, ctx, sizeof(ctx));
> - fprintf(stderr, "%s: init sctx #%d @ %lx: %08x %08x\n", __func__,
> - streamid, sctx->pctx, ctx[0], ctx[1]);
> + fprintf(stderr, "%s: init sctx #%d @ " DMA_ADDR_FMT ": %08x %08x\n",
> + __func__, streamid, sctx->pctx, ctx[0], ctx[1]);
> sct = (ctx[0] >> 1) & 0x07;
> if (epctx->lsa && sct != 1) {
> *cc_error = CC_INVALID_STREAM_TYPE_ERROR;
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-23 19:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-21 21:58 [Qemu-trivial] [PATCH] xhci: fix bad print specifier Hervé Poussineau
2013-02-22 5:40 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2013-02-22 11:26 ` [Qemu-trivial] " Gerd Hoffmann
2013-02-23 16:49 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).