From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UeTN7-0003St-EX for mharc-qemu-trivial@gnu.org; Mon, 20 May 2013 12:55:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeTMw-0003R0-Ry for qemu-trivial@nongnu.org; Mon, 20 May 2013 12:55:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeT4N-00082T-HH for qemu-trivial@nongnu.org; Mon, 20 May 2013 12:36:24 -0400 Received: from mail-gh0-f170.google.com ([209.85.160.170]:52805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeT4C-0007zJ-B1; Mon, 20 May 2013 12:36:08 -0400 Received: by mail-gh0-f170.google.com with SMTP id z10so1406924ghb.1 for ; Mon, 20 May 2013 09:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=uul5twsNMJdtFA6iXUuSvB9z6su5+nQ2RsQqRKJ5xLY=; b=Zw0iX7D8hP57oMsvjdSahjZ803rmFQrn7zILbDWmvcfBQmdUQZRVvPEL39HLoGu5mn y/G8tYbIPk5onFlzGXR8D8/fh/sqF+aN+WS4z2c1fHbiKACCiEJECkW2I5iwBYwdEZLD mGhKnivpU4+RyyXEnMFMtrrvpdoaabbEDFkXrQxZ/JyKvw4xdA7IsKEwlyiBe/52qxQm zNO/RL6KTVuGRnFNrXVQcy1U/lt1SS0WGNbBdQhCjPBRyMDAI98Bx4x6I512q8gaQJas 5PGSxlvhaPyBuVOVK+4MIlBKotCYYA0QCsWFi9ldaNGLpmgA+5OwDLDcw0n4lagthASk JHNQ== X-Received: by 10.236.187.10 with SMTP id x10mr20671368yhm.190.1369067767716; Mon, 20 May 2013 09:36:07 -0700 (PDT) Received: from yakj.usersys.redhat.com (net-37-116-223-193.cust.dsl.vodafone.it. [37.116.223.193]) by mx.google.com with ESMTPSA id b70sm41226681yhm.3.2013.05.20.09.36.04 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 20 May 2013 09:36:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <519A50EE.8040804@redhat.com> Date: Mon, 20 May 2013 18:35:58 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Peter Maydell References: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.170 Cc: Anthony Liguori , patches@linaro.org, qemu-trivial@nongnu.org, John Rigby , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-trivial] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2013 16:55:40 -0000 Il 20/05/2013 18:21, Peter Maydell ha scritto: > Reformat the qapi-schema TargetType enumeration so that it has just > one target architecture name per line. This allows patches for > adding new targets to just add a single line, rather than having > to reformat most of the list (resulting in a hard-to-check diff). > > Signed-off-by: Peter Maydell > --- > d15a9c23 is an example of what you get otherwise. > > I would much prefer it if we autogenerated this list so you didn't > need to change this file at all to add a new target, but Anthony > is against that; so this is at least an improvement. I have queued a patch for 1.6 that would change this field to a free string. There is no use of this enum, not even for introspection. You don't need to know what targets were supported in the version that you compiled from. Only one target is supported in this executable anyway. Paolo > qapi-schema.json | 30 ++++++++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 199744a..a8d361e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3018,10 +3018,32 @@ > # Since: 1.2.0 > ## > { 'enum': 'TargetType', > - 'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblazeel', > - 'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'moxie', > - 'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4', > - 'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xtensa' ] } > + 'data': [ 'alpha', > + 'arm', > + 'cris', > + 'i386', > + 'lm32', > + 'm68k', > + 'microblazeel', > + 'microblaze', > + 'mips64el', > + 'mips64', > + 'mipsel', > + 'mips', > + 'moxie', > + 'or32', > + 'ppc64', > + 'ppcemb', > + 'ppc', > + 's390x', > + 'sh4eb', > + 'sh4', > + 'sparc64', > + 'sparc', > + 'unicore32', > + 'x86_64', > + 'xtensaeb', > + 'xtensa' ] } > > ## > # @TargetInfo: >