From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UhG63-00009d-5r for mharc-qemu-trivial@gnu.org; Tue, 28 May 2013 05:21:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhG5z-00009S-Kw for qemu-trivial@nongnu.org; Tue, 28 May 2013 05:21:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhG5x-0003Qr-Jm for qemu-trivial@nongnu.org; Tue, 28 May 2013 05:21:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhG5x-0003Qn-CZ; Tue, 28 May 2013 05:21:29 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4S9LRih021024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 May 2013 05:21:27 -0400 Received: from yakj.usersys.redhat.com (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4S9LNlV014963; Tue, 28 May 2013 05:21:24 -0400 Message-ID: <51A4770D.5010006@redhat.com> Date: Tue, 28 May 2013 11:21:17 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: =?ISO-8859-15?Q?Andreas_F=E4rber?= References: <1369698254-32350-1-git-send-email-aik@ozlabs.ru> <1369698583-32533-1-git-send-email-aik@ozlabs.ru> <51A470A9.8000502@redhat.com> <51A474EC.6070604@suse.de> In-Reply-To: <51A474EC.6070604@suse.de> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-15 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id r4S9LRih021024 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Alexey Kardashevskiy , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Peter Maydell Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2013 09:21:33 -0000 Il 28/05/2013 11:12, Andreas F=E4rber ha scritto: > Am 28.05.2013 10:54, schrieb Paolo Bonzini: >> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto: >>> The symlink to "asm" platform linux headers is made in the build tree= by >>> the configure script but gcc is not told to look for them there. >>> >>> The patch fixes this. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> >>> The previous patch did not remove the old line adding includes. Early= morning, >>> lack of focus :) >>> >>> --- >>> configure | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 5ae7e4a..eca2a20 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -547,7 +547,7 @@ Haiku) >>> if [ "$cpu" =3D "i386" -o "$cpu" =3D "x86_64" ] ; then >>> audio_possible_drivers=3D"$audio_possible_drivers fmod" >>> fi >>> - QEMU_INCLUDES=3D"-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES" >>> + QEMU_INCLUDES=3D"-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-heade= rs $QEMU_INCLUDES" >>> ;; >>> esac >>> =20 >>> >> >> Reviewed-by: Paolo Bonzini >=20 > Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't > this just be -Ilinux-headers? I think -Ilinux-headers would add /x86_64-softmmu/linux-headers, which is wrong. > And might it make sense to give the build directory precedence over the > source directory? It shouldn't matter. Paolo