From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VJm0a-0001H1-VF for mharc-qemu-trivial@gnu.org; Wed, 11 Sep 2013 11:07:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJm0T-00016G-9Q for qemu-trivial@nongnu.org; Wed, 11 Sep 2013 11:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJm0N-0006ND-BD for qemu-trivial@nongnu.org; Wed, 11 Sep 2013 11:07:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJm0A-0006Jp-Hc; Wed, 11 Sep 2013 11:06:42 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8BF6ZpA028229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Sep 2013 11:06:36 -0400 Received: from yakj.usersys.redhat.com (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8BF6Vwk014752; Wed, 11 Sep 2013 11:06:32 -0400 Message-ID: <52308701.1020706@redhat.com> Date: Wed, 11 Sep 2013 17:06:41 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Gabriel Kerneis References: <1378906912-14015-1-git-send-email-gabriel@kerneis.info> <523077CE.6070303@redhat.com> <20130911144230.GA15227@kerneis.info> <523083EF.7050203@redhat.com> <20130911150137.GC15227@kerneis.info> In-Reply-To: <20130911150137.GC15227@kerneis.info> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, Peter Maydell , Eric Blake , qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2013 15:07:07 -0000 Il 11/09/2013 17:01, Gabriel Kerneis ha scritto: > On Wed, Sep 11, 2013 at 04:53:35PM +0200, Paolo Bonzini wrote: >> Oh, then it's this line in configure that has to be changed to do proper >> quoting. >> >> printf "# Configured with:" >> $config_host_mak >> printf " '%s'" "$0" "$@" >> $config_host_mak > > No, this line has absolutely nothing to do with it. It's purely a > comment that is not executed later. Actually it is... :) See here: sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh and relate it to your error message: config-host.mak is out-of-date, running configure sh: 1: Syntax error: "(" unexpected make: *** [config-host.mak] Error 2 Your argument is using '', so it conflicts with configure's own use of '' to quote the arguments. > The line that has to be fixed is > really the line starting with "extra_cflags=" in config-host.mak (well, > at least in my experience - my patch does not touch the first line, at > it still solves the issue). Yeah, what I'm missing now is why your patch works. > Unfortunately, %q is not portable and we probably need something along > the lines of your proposal above (note that it doesn't handle "(" > though, which is precisely the one causing an issue in my example). It doesn't need to handle it, because it is not a special character within quotes. Paolo