From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-trivial] [PATCH trivial] qemu-img: Remove redundancy "ret = -1"
Date: Wed, 09 Jul 2014 15:58:44 +0200 [thread overview]
Message-ID: <53BD4A94.2000300@msgid.tls.msk.ru> (raw)
In-Reply-To: <53B57D5B.2070204@gmail.com>
03.07.2014 17:57, Chen Gang wrote:
> In this case, 'ret' is already '-1', so need not do it again.
It's a very minor thing in an error path, maybe compiler even
eliminates this statement entirely by its own already.
Not sure it is worth the effort but applied to the -trivial tree
anyway, thanks!
/mjt
next prev parent reply other threads:[~2014-07-09 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 15:57 [Qemu-trivial] [PATCH trivial] qemu-img: Remove redundancy "ret = -1" Chen Gang
2014-07-09 13:58 ` Michael Tokarev [this message]
2014-07-10 2:33 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD4A94.2000300@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=gang.chen.5i5j@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).