From: Richard Henderson <rth@twiddle.net>
To: Michael Tokarev <mjt@tls.msk.ru>,
"Michael S. Tsirkin" <mst@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: kwolf@redhat.com, lkurusa@redhat.com, qemu-trivial@nongnu.org,
jan.kiszka@siemens.com, riku.voipio@iki.fi,
luonengjun@huawei.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, stefanha@redhat.com,
Li Liu <john.liuli@huawei.com>,
pbonzini@redhat.com, peter.huangpeng@huawei.com,
alex.bennee@linaro.org
Subject: Re: [Qemu-trivial] [PATCH v6 09/10] tcg: check return value of fopen()
Date: Fri, 15 Aug 2014 06:53:19 -1000 [thread overview]
Message-ID: <53EE3AFF.8020005@twiddle.net> (raw)
In-Reply-To: <53EE212A.60405@msgid.tls.msk.ru>
On 08/15/2014 05:03 AM, Michael Tokarev wrote:
>>> f = fopen("/tmp/op.log", "w");
>
> Gosh. So why are we still use fixed filenames in /tmp?????
> Every such use is a potential security holw... :( Ughm.
>
> Can't we get rid of this somehow, by requiring a filename
> parameter for example?
It's in code that isn't compiled in by default.
Better than taking a parameter, or doing something else one-off, I think it'd
be best to dump this to the normal log file. I.e. use qemu_log instead of fprintf.
r~
next prev parent reply other threads:[~2014-08-15 16:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 7:29 [Qemu-trivial] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-14 10:19 ` Michael S. Tsirkin
2014-08-15 14:58 ` Michael Tokarev
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 02/10] monitor: " zhanghailiang
2014-08-14 10:30 ` Michael S. Tsirkin
2014-08-15 18:25 ` Luiz Capitulino
2014-08-17 9:45 ` Michael S. Tsirkin
2014-08-17 10:55 ` Michael S. Tsirkin
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 03/10] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-14 10:37 ` Michael S. Tsirkin
2014-08-14 10:39 ` Michael Tokarev
2014-08-14 11:16 ` Michael S. Tsirkin
2014-08-18 11:49 ` Michael Tokarev
2014-08-18 20:17 ` Michael S. Tsirkin
2014-08-19 7:19 ` Michael Tokarev
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-14 10:12 ` Michael S. Tsirkin
2014-08-15 14:59 ` Michael Tokarev
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 05/10] util/path: Use the GLib memory allocation routines zhanghailiang
2014-08-14 10:15 ` Michael S. Tsirkin
2014-08-18 5:59 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 06/10] slirp/misc: Use g_malloc() instead of malloc() zhanghailiang
2014-08-14 10:31 ` Michael S. Tsirkin
2014-08-18 0:29 ` zhanghailiang
2014-08-18 5:56 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 07/10] linux-user: check return value " zhanghailiang
2014-08-14 13:31 ` [Qemu-trivial] [Qemu-devel] " Riku Voipio
2014-08-14 18:04 ` Michael Tokarev
2014-08-18 20:17 ` Michael S. Tsirkin
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 08/10] tests/bios-tables-test: check the value returned by fopen() zhanghailiang
2014-08-14 10:32 ` Michael S. Tsirkin
2014-08-18 0:32 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-14 10:33 ` Michael S. Tsirkin
2014-08-15 15:03 ` Michael Tokarev
2014-08-15 16:53 ` Richard Henderson [this message]
2014-08-18 6:21 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-trivial] [PATCH v6 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang
2014-08-14 10:36 ` Michael S. Tsirkin
2014-08-18 0:55 ` zhanghailiang
2014-08-14 10:17 ` [Qemu-trivial] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse Michael S. Tsirkin
2014-08-14 10:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE3AFF.8020005@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=john.liuli@huawei.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lkurusa@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).