From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Johny Mattsson <jmattsson@dius.com.au>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] Fix pflash_cfi01 to restore flash command/array state after migration
Date: Thu, 21 Aug 2014 11:58:48 +0200 [thread overview]
Message-ID: <53F5C2D8.8050106@redhat.com> (raw)
In-Reply-To: <CAFEAcA_bCOTLT1jvvJp+Wtaah43qb-UQgzxRuZc3WcyzNPrjSw@mail.gmail.com>
Il 21/08/2014 11:22, Peter Maydell ha scritto:
> On 21 August 2014 08:35, Johny Mattsson <jmattsson@dius.com.au> wrote:
>> > When using snapshots on e.g. the VersatilePB board, the pflash driver
>> > would report an error and get reset at times after resuming the snapshot.
>> > This was traced down to the 'romd' flag in the pflash emulation which was
>> > not being persisted in the snapshot.
>> >
>> > Author: Bernd Meyer <bmeyer@dius.com.au>
>> > Signed-off-by: Johny Mattsson <jmattsson@dius.com.au>
> Paolo -- remind me, is it the device model's job to keep track of
> what its memory regions are doing, rather than the memory region's
> job to make sure it's migrated? I definitely remember having this
> argument with Avi before but I can't remember the outcome...
>
It's the device model's job. I agree with your review, and I think
romd=1 is the right default value if the subsection is not present.
Paolo
next prev parent reply other threads:[~2014-08-21 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 7:35 [Qemu-trivial] [PATCH] Fix pflash_cfi01 to restore flash command/array state after migration Johny Mattsson
2014-08-21 9:22 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2014-08-21 9:58 ` Paolo Bonzini [this message]
2014-08-21 9:48 ` Markus Armbruster
2014-08-22 7:53 ` Johny Mattsson
2014-08-22 9:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5C2D8.8050106@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattsson@dius.com.au \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).