From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Zhang Han <zhanghan64@huawei.com>, jasowang@redhat.com
Cc: alex.chen@huawei.com, hunongda@huawei.com,
qemu-trivial@nongnu.org, hang.zhanghailiang@huawei.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 7/9] net: Remove assignment in if condition
Date: Thu, 14 Jan 2021 12:35:38 +0100 [thread overview]
Message-ID: <5426b47e-cd7c-de59-bd70-b74c69ba4904@redhat.com> (raw)
In-Reply-To: <20201222082340.67405-8-zhanghan64@huawei.com>
On 12/22/20 9:23 AM, Zhang Han wrote:
> Put the assignment before the if condition
>
> Signed-off-by: Zhang Han <zhanghan64@huawei.com>
> ---
> net/tap-bsd.c | 3 ++-
> net/tap-solaris.c | 9 ++++++---
> 2 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-01-14 11:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 8:23 [PATCH 0/9] Fix some style problems in net Zhang Han
2020-12-22 8:23 ` [PATCH 1/9] net: Add spaces around operator/delete redundant spaces Zhang Han
2020-12-22 8:23 ` [PATCH 2/9] net: Add braces for statements/fix braces' position Zhang Han
2020-12-22 8:23 ` [PATCH 3/9] net: Transfer // comments to /**/ Zhang Han
2020-12-22 8:23 ` [PATCH 4/9] net: Transfer "foo* " to "foo *" Zhang Han
2020-12-22 8:23 ` [PATCH 5/9] net: Fix lines over 90 characters Zhang Han
2020-12-22 8:23 ` [PATCH 6/9] net: Transfer tabs to spcaes Zhang Han
2021-01-14 11:34 ` Philippe Mathieu-Daudé
2020-12-22 8:23 ` [PATCH 7/9] net: Remove assignment in if condition Zhang Han
2021-01-14 11:35 ` Philippe Mathieu-Daudé [this message]
2020-12-22 8:23 ` [PATCH 8/9] net: Remove initialization of static ints Zhang Han
2020-12-22 8:23 ` [PATCH 9/9] net: Fix the indent problems Zhang Han
2020-12-22 17:00 ` [PATCH 0/9] Fix some style problems in net no-reply
2021-01-14 2:34 ` zhanghan (J)
2021-02-01 6:18 ` zhanghan (J)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5426b47e-cd7c-de59-bd70-b74c69ba4904@redhat.com \
--to=philmd@redhat.com \
--cc=alex.chen@huawei.com \
--cc=hang.zhanghailiang@huawei.com \
--cc=hunongda@huawei.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhanghan64@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).