From: Thomas Huth <thuth@redhat.com>
To: Gustavo Romero <gustavo.romero@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, philmd@linaro.org, alex.bennee@linaro.org
Subject: Re: [PATCH] hw/net/e1000: Remove stray empty comment in header
Date: Mon, 5 May 2025 12:10:39 +0200 [thread overview]
Message-ID: <55970655-386d-4cac-a70b-1eca0fad8696@redhat.com> (raw)
In-Reply-To: <20250504215639.54860-4-gustavo.romero@linaro.org>
On 04/05/2025 23.56, Gustavo Romero wrote:
> In the header file, remove a stray empty comment in the Offload Context
> Descriptor struct.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
> hw/net/e1000x_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h
> index cd896fc0ca..e9a74de6f4 100644
> --- a/hw/net/e1000x_regs.h
> +++ b/hw/net/e1000x_regs.h
> @@ -900,7 +900,7 @@ struct e1000_context_desc {
> uint16_t tucse; /* TCP checksum end */
> } tcp_fields;
> } upper_setup;
> - uint32_t cmd_and_length; /* */
> + uint32_t cmd_and_length;
> union {
> uint32_t data;
> struct {
There is another one in hw/net/eepro100.c ...
Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2025-05-05 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 21:56 [PATCH] hw/net/e1000: Remove stray empty comment in header Gustavo Romero
2025-05-05 10:10 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55970655-386d-4cac-a70b-1eca0fad8696@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=gustavo.romero@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).