* [PATCH] hw/net/e1000: Remove stray empty comment in header
@ 2025-05-04 21:56 Gustavo Romero
2025-05-05 10:10 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Romero @ 2025-05-04 21:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, philmd, alex.bennee, gustavo.romero
In the header file, remove a stray empty comment in the Offload Context
Descriptor struct.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
---
hw/net/e1000x_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h
index cd896fc0ca..e9a74de6f4 100644
--- a/hw/net/e1000x_regs.h
+++ b/hw/net/e1000x_regs.h
@@ -900,7 +900,7 @@ struct e1000_context_desc {
uint16_t tucse; /* TCP checksum end */
} tcp_fields;
} upper_setup;
- uint32_t cmd_and_length; /* */
+ uint32_t cmd_and_length;
union {
uint32_t data;
struct {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/net/e1000: Remove stray empty comment in header
2025-05-04 21:56 [PATCH] hw/net/e1000: Remove stray empty comment in header Gustavo Romero
@ 2025-05-05 10:10 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2025-05-05 10:10 UTC (permalink / raw)
To: Gustavo Romero, qemu-devel; +Cc: qemu-trivial, philmd, alex.bennee
On 04/05/2025 23.56, Gustavo Romero wrote:
> In the header file, remove a stray empty comment in the Offload Context
> Descriptor struct.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
> hw/net/e1000x_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h
> index cd896fc0ca..e9a74de6f4 100644
> --- a/hw/net/e1000x_regs.h
> +++ b/hw/net/e1000x_regs.h
> @@ -900,7 +900,7 @@ struct e1000_context_desc {
> uint16_t tucse; /* TCP checksum end */
> } tcp_fields;
> } upper_setup;
> - uint32_t cmd_and_length; /* */
> + uint32_t cmd_and_length;
> union {
> uint32_t data;
> struct {
There is another one in hw/net/eepro100.c ...
Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-05 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-04 21:56 [PATCH] hw/net/e1000: Remove stray empty comment in header Gustavo Romero
2025-05-05 10:10 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).