From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1a2LfZ-0006ON-7r for mharc-qemu-trivial@gnu.org; Fri, 27 Nov 2015 11:14:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2LfW-0006KN-PY for qemu-trivial@nongnu.org; Fri, 27 Nov 2015 11:14:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2LfV-0005v1-JJ for qemu-trivial@nongnu.org; Fri, 27 Nov 2015 11:14:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2LfR-0005uK-J8; Fri, 27 Nov 2015 11:14:37 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DB1DAC0B7AB4; Fri, 27 Nov 2015 16:14:35 +0000 (UTC) Received: from [10.36.112.19] (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tARGEWx1007695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Nov 2015 11:14:34 -0500 To: Markus Armbruster References: <1448626105-29540-1-git-send-email-pbonzini@redhat.com> <87oaefzeuh.fsf@blackfin.pond.sub.org> <56586B7D.2040205@redhat.com> <877fl3v5fm.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <56588168.2070003@redhat.com> Date: Fri, 27 Nov 2015 17:14:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <877fl3v5fm.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 16:14:43 -0000 On 27/11/2015 16:16, Markus Armbruster wrote: >>> >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >>> >> checked them all. >>> >> >>> >> Reviewed-by: Markus Armbruster >> > >> > No, I just copied the upstream bluez patch. > At least CREATE_CONN_CANCEL_CP_SIZE is also wrong. > > Any particular reason not to mass-convert to sizeof and call it a day? No particular reason, but it is bluetooth after all. :) Paolo