From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
Ashley Jonathan <jonathan.ashley@altran.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed
Date: Mon, 11 Jan 2016 10:13:36 +0100 [thread overview]
Message-ID: <56937240.2080305@redhat.com> (raw)
In-Reply-To: <569368F6.3050704@msgid.tls.msk.ru>
On 11/01/2016 09:33, Michael Tokarev wrote:
> 11.12.2015 14:29, Ashley Jonathan wrote:
>> I have experienced a minor difficulty using QEMU with the "-serial pty" option:
>>
>> If a process opens the slave pts device, writes data to it, then immediately closes it, the data doesn't reliably get delivered to the emulated serial port. This seems to be because a read of the master pty device returns EIO on Linux if no process has the pts device open, even when data is waiting "in the pipe".
>>
>> A fix seems to be for QEMU to keep the pts file descriptor open until the pty is closed, as per the below patch.
>
> The patch looks fine, so
>
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
>
> but I'd love to have an ACK from the maintainer about this one,
> or for it to pick it up.
Ok, I'll pick it up after I've read up a bit more on PTYs.
Paolo
next prev parent reply other threads:[~2016-01-11 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 11:29 [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed Ashley Jonathan
2016-01-11 8:33 ` Michael Tokarev
2016-01-11 9:13 ` Paolo Bonzini [this message]
2016-02-12 2:29 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2016-02-12 13:51 ` Marc-André Lureau
2016-01-11 9:16 ` [Qemu-trivial] " Paolo Bonzini
2016-01-11 9:29 ` Ashley Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56937240.2080305@redhat.com \
--to=pbonzini@redhat.com \
--cc=jonathan.ashley@altran.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).