From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Bligh <alex@alex.org.uk>, Eric Blake <eblake@redhat.com>
Cc: Quentin Casasnovas <quentin.casasnovas@oracle.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>,
qemu block <qemu-block@nongnu.org>
Subject: Re: [Qemu-trivial] [Nbd] [Qemu-devel] [PATCH] nbd: fix trim/discard commands with a length bigger than NBD_MAX_BUFFER_SIZE
Date: Tue, 10 May 2016 19:55:56 +0200 [thread overview]
Message-ID: <573220AC.9010704@redhat.com> (raw)
In-Reply-To: <672ED845-88C6-4C96-B2DC-F4BCBD85F788@alex.org.uk>
On 10/05/2016 17:38, Alex Bligh wrote:
> > and are at the
> > mercy of however the kernel currently decides to split large requests).
>
> I am surprised TRIM doesn't get broken up the same way READ and WRITE
> do.
The payload of TRIM has constant size, so it makes sense to do that.
The kernel then self-imposes a 2GB limit in blkdev_issue_discard.
On the other hand, READ and WRITE of size n can possibly require O(n)
memory.
Paolo
next prev parent reply other threads:[~2016-05-10 17:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 8:45 [Qemu-trivial] [PATCH] nbd: fix trim/discard commands with a length bigger than NBD_MAX_BUFFER_SIZE Quentin Casasnovas
2016-05-10 14:01 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-05-10 15:08 ` [Qemu-trivial] [Nbd] " Alex Bligh
2016-05-10 15:29 ` Eric Blake
2016-05-10 15:38 ` Alex Bligh
2016-05-10 15:45 ` Quentin Casasnovas
2016-05-10 15:49 ` Alex Bligh
2016-05-10 16:04 ` Quentin Casasnovas
2016-05-10 16:23 ` Alex Bligh
2016-05-10 16:27 ` Quentin Casasnovas
2016-05-11 9:38 ` Paolo Bonzini
2016-05-11 14:08 ` Eric Blake
2016-05-11 14:55 ` Alex Bligh
2016-05-11 15:08 ` Paolo Bonzini
2016-05-10 17:55 ` Paolo Bonzini [this message]
2016-05-11 21:12 ` Wouter Verhelst
2016-05-12 15:33 ` Alex Bligh
2016-05-10 15:41 ` Alex Bligh
2016-05-10 15:46 ` Eric Blake
2016-05-10 15:52 ` Alex Bligh
2016-05-10 15:54 ` Quentin Casasnovas
2016-05-10 16:33 ` Quentin Casasnovas
2016-05-10 20:24 ` Eric Blake
2016-05-10 19:13 ` Michał Belczyk
2016-05-11 21:10 ` Wouter Verhelst
2016-05-11 21:06 ` Wouter Verhelst
2016-05-12 15:03 ` Alex Bligh
2016-05-10 20:34 ` [Qemu-trivial] " Eric Blake
2016-05-11 8:34 ` Quentin Casasnovas
2016-05-11 14:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573220AC.9010704@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=eblake@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quentin.casasnovas@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).