Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

Am 29.04.2016 um 10:51 schrieb Peter Maydell:
> On 28 April 2016 at 22:33, Stefan Weil <sw@weilnetz.de> wrote:
>> The clang compiler supports a useful compiler option -Weverything.
>>
>> As this option triggers warnings in glib header files, too, testing
>> glib with -Werror will always fail. A size mismatch is also detected
>> without -Werror, so simply remove it.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> With this patch, it is possible to build QEMU using this configuration:
>>
>> ./configure' --cc=clang-3.7 --cxx=clang++-3.7 --extra-cflags="-Weverything -DHAVE_FSXATTR" --disable-werror
>>
>> (HAVE_FSXATTR avoids a fatal build error because of structure redefinition)
> 
> No objection to the patch, but not for 2.6 at this stage I think.
> 
> (Does the configure patch re fsxattr that got a ping today
> avoid your need to define HAVE_FSXATTR by hand?)
> 
> thanks
> -- PMM
> 

I think this patch which was too late for 2.6.0 is a candidate for
qemu-trivial, maybe also for qemu-stable. CC both mailing lists.

Stefan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Paolo Bonzini]

On 16/05/2016 13:27, Stefan Weil wrote:
> I think this patch which was too late for 2.6.0 is a candidate for
> qemu-trivial, maybe also for qemu-stable. CC both mailing lists.

Yes, it is confusing to have --disable-werror compilations break because
of warnings becoming errors.  However, the subject is imprecise, what about:

----
configure: Allow builds with extra warnings

The clang compiler supports a useful compiler option -Weverything,
and GCC also has other warnings not enabled by -Wall.

If glib header files trigger a warning, however, testing glib with
-Werror will always fail. A size mismatch is also detected without
-Werror, so simply remove it.
----

Thanks,

Paolo

Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

Am 16.05.2016 um 14:22 schrieb Paolo Bonzini:
> 
> 
> On 16/05/2016 13:27, Stefan Weil wrote:
>> I think this patch which was too late for 2.6.0 is a candidate for
>> qemu-trivial, maybe also for qemu-stable. CC both mailing lists.
> 
> Yes, it is confusing to have --disable-werror compilations break because
> of warnings becoming errors.  However, the subject is imprecise, what about:
> 
> ----
> configure: Allow builds with extra warnings
> 
> The clang compiler supports a useful compiler option -Weverything,
> and GCC also has other warnings not enabled by -Wall.
> 
> If glib header files trigger a warning, however, testing glib with
> -Werror will always fail. A size mismatch is also detected without
> -Werror, so simply remove it.
> ----
> 
> Thanks,
> 
> Paolo


Yes, that's a better description. Maybe Michael can use it when
applying the patch.

Stefan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Paolo Bonzini]

[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]



On 16/05/2016 14:32, Stefan Weil wrote:
> Am 16.05.2016 um 14:22 schrieb Paolo Bonzini:
>>
>>
>> On 16/05/2016 13:27, Stefan Weil wrote:
>>> I think this patch which was too late for 2.6.0 is a candidate for
>>> qemu-trivial, maybe also for qemu-stable. CC both mailing lists.
>>
>> Yes, it is confusing to have --disable-werror compilations break because
>> of warnings becoming errors.  However, the subject is imprecise, what about:
>>
>> ----
>> configure: Allow builds with extra warnings
>>
>> The clang compiler supports a useful compiler option -Weverything,
>> and GCC also has other warnings not enabled by -Wall.
>>
>> If glib header files trigger a warning, however, testing glib with
>> -Werror will always fail. A size mismatch is also detected without
>> -Werror, so simply remove it.
>> ----
>>
>> Thanks,
>>
>> Paolo
> 
> 
> Yes, that's a better description. Maybe Michael can use it when
> applying the patch.

I'm sending a pull request with all sort of patches in a couple days, I
can include this one too.

Paolo


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]