From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/6] hw/bt: Don't use cpu_to_*w() and *_to_cpup()
Date: Tue, 28 Jun 2016 09:27:28 -0600 [thread overview]
Message-ID: <57729760.6030603@redhat.com> (raw)
In-Reply-To: <1467125451-16700-4-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 711 bytes --]
On 06/28/2016 08:50 AM, Peter Maydell wrote:
> Don't use cpu_to_*w() and *_to_cpup() to do byte-swapped loads
> and stores; instead use ld*_p() and st*_p() which correctly handle
> misaligned accesses.
>
> Bring the HNDL() macro into line with how we deal with
> PARAMHANDLE(), by using cpu_to_le16() rather than an ifdef
> HOST_WORDS_BIGENDIAN.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/bt/hci.c | 10 +++-------
> hw/bt/l2cap.c | 12 ++++++------
> 2 files changed, 9 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-28 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 14:50 [Qemu-trivial] [PATCH 0/6] Drop cpu_to_*w, *_to_cpup, document cpu_to_*, *_to_cpu Peter Maydell
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions Peter Maydell
2016-06-28 15:09 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 2/6] block/qcow2: Don't use cpu_to_*w() Peter Maydell
2016-06-28 15:13 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-06-28 15:13 ` Peter Maydell
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 3/6] hw/bt: Don't use cpu_to_*w() and *_to_cpup() Peter Maydell
2016-06-28 15:27 ` Eric Blake [this message]
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 4/6] bswap.h: Remove unused " Peter Maydell
2016-06-28 15:38 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 5/6] bswap.h: Fix comment typo Peter Maydell
2016-06-28 15:05 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 6/6] bswap.h: Document cpu_to_* and *_to_cpu conversion functions Peter Maydell
2016-06-28 14:58 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2016-06-28 15:40 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57729760.6030603@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).