* Re: [Qemu-trivial] [Qemu-devel] [PATCH v9 02/13] mptsas: change .realize function name
[not found] ` <1466403224-16604-3-git-send-email-caoj.fnst@cn.fujitsu.com>
@ 2016-07-06 3:02 ` Cao jin
2016-09-14 7:57 ` [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 2+ messages in thread
From: Cao jin @ 2016-07-06 3:02 UTC (permalink / raw)
To: Paolo Bonzini, qemu-trivial
Cc: qemu-devel, Marcel Apfelbaum, Markus Armbruster,
Michael S. Tsirkin
Hi,
I guess this one is suitable for trivial tree, so CC them
On 06/20/2016 02:13 PM, Cao jin wrote:
> All the other devices` .realize function name are xxx_realize, except this one.
>
> cc: Michael S. Tsirkin <mst@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
> cc: Paolo Bonzini <pbonzini@redhat.com>
> cc: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/scsi/mptsas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
> index be88e16..ae8514e 100644
> --- a/hw/scsi/mptsas.c
> +++ b/hw/scsi/mptsas.c
> @@ -1269,7 +1269,7 @@ static const struct SCSIBusInfo mptsas_scsi_info = {
> .load_request = mptsas_load_request,
> };
>
> -static void mptsas_scsi_init(PCIDevice *dev, Error **errp)
> +static void mptsas_scsi_realize(PCIDevice *dev, Error **errp)
> {
> DeviceState *d = DEVICE(dev);
> MPTSASState *s = MPT_SAS(dev);
> @@ -1412,7 +1412,7 @@ static void mptsas1068_class_init(ObjectClass *oc, void *data)
> DeviceClass *dc = DEVICE_CLASS(oc);
> PCIDeviceClass *pc = PCI_DEVICE_CLASS(oc);
>
> - pc->realize = mptsas_scsi_init;
> + pc->realize = mptsas_scsi_realize;
> pc->exit = mptsas_scsi_uninit;
> pc->romfile = 0;
> pc->vendor_id = PCI_VENDOR_ID_LSI_LOGIC;
>
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-trivial] [PATCH v9 02/13] mptsas: change .realize function name
[not found] ` <1466403224-16604-3-git-send-email-caoj.fnst@cn.fujitsu.com>
2016-07-06 3:02 ` [Qemu-trivial] [Qemu-devel] [PATCH v9 02/13] mptsas: change .realize function name Cao jin
@ 2016-09-14 7:57 ` Michael Tokarev
1 sibling, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2016-09-14 7:57 UTC (permalink / raw)
To: Cao jin, qemu-devel
Cc: Marcel Apfelbaum, Paolo Bonzini, Markus Armbruster,
Michael S. Tsirkin, qemu-trivial
20.06.2016 09:13, Cao jin wrote:
> All the other devices` .realize function name are xxx_realize, except this one.
Applied to -trivial, thanks!
/mjt
> cc: Michael S. Tsirkin <mst@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
> cc: Paolo Bonzini <pbonzini@redhat.com>
> cc: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/scsi/mptsas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
> index be88e16..ae8514e 100644
> --- a/hw/scsi/mptsas.c
> +++ b/hw/scsi/mptsas.c
> @@ -1269,7 +1269,7 @@ static const struct SCSIBusInfo mptsas_scsi_info = {
> .load_request = mptsas_load_request,
> };
>
> -static void mptsas_scsi_init(PCIDevice *dev, Error **errp)
> +static void mptsas_scsi_realize(PCIDevice *dev, Error **errp)
> {
> DeviceState *d = DEVICE(dev);
> MPTSASState *s = MPT_SAS(dev);
> @@ -1412,7 +1412,7 @@ static void mptsas1068_class_init(ObjectClass *oc, void *data)
> DeviceClass *dc = DEVICE_CLASS(oc);
> PCIDeviceClass *pc = PCI_DEVICE_CLASS(oc);
>
> - pc->realize = mptsas_scsi_init;
> + pc->realize = mptsas_scsi_realize;
> pc->exit = mptsas_scsi_uninit;
> pc->romfile = 0;
> pc->vendor_id = PCI_VENDOR_ID_LSI_LOGIC;
>
^ permalink raw reply [flat|nested] 2+ messages in thread