* Re: [Qemu-trivial] [PATCH 1/1] migration: fix compiler warning on uninitialized variable
[not found] <259818682e41b95ae60f1423b87954a3fe377639.1477950393.git.jcody@redhat.com>
@ 2016-11-01 1:12 ` Hailiang Zhang
0 siblings, 0 replies; only message in thread
From: Hailiang Zhang @ 2016-11-01 1:12 UTC (permalink / raw)
To: Jeff Cody, qemu-devel
Cc: qemu-block, mark.cave-ayland, quintela, Michael Tokarev,
qemu-trivial
On 2016/11/1 5:50, Jeff Cody wrote:
> Some older GCC versions (e.g. 4.4.7) report a warning on an
> uninitialized variable for 'request', even though all possible code
> paths that reference 'request' will be initialized. To appease
> these versions, initialize the variable to 0.
>
Thanks for reporting this, I think this patch can go through trivial
branch.
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> migration/colo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index e7224b8..93c85c5 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -439,7 +439,7 @@ void *colo_process_incoming_thread(void *opaque)
> }
>
> while (mis->state == MIGRATION_STATUS_COLO) {
> - int request;
> + int request = 0;
>
> colo_wait_handle_message(mis->from_src_file, &request, &local_err);
> if (local_err) {
>
^ permalink raw reply [flat|nested] only message in thread