* [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus
@ 2016-11-01 5:51 zhanghailiang
2016-11-01 14:28 ` Eric Blake
2016-11-02 7:18 ` Markus Armbruster
0 siblings, 2 replies; 5+ messages in thread
From: zhanghailiang @ 2016-11-01 5:51 UTC (permalink / raw)
To: eblake; +Cc: armbru, qemu-trivial, zhanghailiang
VM can not get into colo state unless users enable 'x-colo'
capability for migration, Here it is necessary to clarify
this.
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
qapi-schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 8a7b527..d580169 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -462,7 +462,8 @@
#
# @failed: some error occurred during migration process.
#
-# @colo: VM is in the process of fault tolerance. (since 2.8)
+# @colo: VM is in the process of fault tolerance, VM can not get into this
+# state unless colo capability is enabled for migration. (since 2.8)
#
# Since: 2.3
#
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-01 5:51 [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
@ 2016-11-01 14:28 ` Eric Blake
2016-11-02 7:28 ` Hailiang Zhang
2016-11-02 7:18 ` Markus Armbruster
1 sibling, 1 reply; 5+ messages in thread
From: Eric Blake @ 2016-11-01 14:28 UTC (permalink / raw)
To: zhanghailiang; +Cc: armbru, qemu-trivial
[-- Attachment #1.1: Type: text/plain, Size: 1086 bytes --]
On 11/01/2016 12:51 AM, zhanghailiang wrote:
> VM can not get into colo state unless users enable 'x-colo'
> capability for migration, Here it is necessary to clarify
> this.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> qapi-schema.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8a7b527..d580169 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -462,7 +462,8 @@
> #
> # @failed: some error occurred during migration process.
> #
> -# @colo: VM is in the process of fault tolerance. (since 2.8)
> +# @colo: VM is in the process of fault tolerance, VM can not get into this
> +# state unless colo capability is enabled for migration. (since 2.8)
This hunk is for MigrationStatus; can you also add similar wording for
the documentation of RunState? Looking forward to v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-01 14:28 ` Eric Blake
@ 2016-11-02 7:28 ` Hailiang Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Hailiang Zhang @ 2016-11-02 7:28 UTC (permalink / raw)
To: Eric Blake; +Cc: armbru, qemu-trivial
On 2016/11/1 22:28, Eric Blake wrote:
> On 11/01/2016 12:51 AM, zhanghailiang wrote:
>> VM can not get into colo state unless users enable 'x-colo'
>> capability for migration, Here it is necessary to clarify
>> this.
>>
>> Suggested-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> ---
>> qapi-schema.json | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 8a7b527..d580169 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -462,7 +462,8 @@
>> #
>> # @failed: some error occurred during migration process.
>> #
>> -# @colo: VM is in the process of fault tolerance. (since 2.8)
>> +# @colo: VM is in the process of fault tolerance, VM can not get into this
>> +# state unless colo capability is enabled for migration. (since 2.8)
>
> This hunk is for MigrationStatus; can you also add similar wording for
> the documentation of RunState? Looking forward to v2.
>
OK, no problem, will send v2.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-01 5:51 [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
2016-11-01 14:28 ` Eric Blake
@ 2016-11-02 7:18 ` Markus Armbruster
2016-11-02 7:28 ` Hailiang Zhang
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2016-11-02 7:18 UTC (permalink / raw)
To: zhanghailiang; +Cc: eblake, qemu-trivial
You forgot to copy qemu@nongnu.org. Please resend.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-02 7:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-01 5:51 [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
2016-11-01 14:28 ` Eric Blake
2016-11-02 7:28 ` Hailiang Zhang
2016-11-02 7:18 ` Markus Armbruster
2016-11-02 7:28 ` Hailiang Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).