* Re: [PULL 22/24] hw/misc/stm32_rcc: Fix stm32_rcc_write() arguments order
[not found] ` <20250610125633.24411-23-philmd@linaro.org>
@ 2025-07-01 10:31 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; only message in thread
From: Philippe Mathieu-Daudé @ 2025-07-01 10:31 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel, Philippe Michaud-Boudreault, QEMU Trivial
On 10/6/25 14:56, Philippe Mathieu-Daudé wrote:
> From: Philippe Michaud-Boudreault <philmb3487@proton.me>
>
> The tracing function for the write case incorrectly has
> parameters switched around. So order them in the correct way.
>
> Signed-off-by: Philippe Michaud-Boudreault <philmb3487@proton.me>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Message-Id: <HnyjTNqwrfGusE44bnM7kuLuj13Di1VgXN-dXVHMOSnfgCUhoipOVIoVS1WQaKrJxmEDy9XJGdlQj6zVTIdJE0QVlfBhfbcckFFWRRP56uY=@proton.me>
FTR, since qemu-trivial@ isn't archived on LORE, the original patch is:
https://lists.gnu.org/archive/html/qemu-trivial/2025-06/msg00002.html
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/misc/stm32_rcc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32_rcc.c b/hw/misc/stm32_rcc.c
> index 94e8dae441c..5815b3efa54 100644
> --- a/hw/misc/stm32_rcc.c
> +++ b/hw/misc/stm32_rcc.c
> @@ -60,7 +60,7 @@ static void stm32_rcc_write(void *opaque, hwaddr addr,
> uint32_t value = val64;
> uint32_t prev_value, new_value, irq_offset;
>
> - trace_stm32_rcc_write(value, addr);
> + trace_stm32_rcc_write(addr, value);
>
> if (addr > STM32_RCC_DCKCFGR2) {
> qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%"HWADDR_PRIx"\n",
^ permalink raw reply [flat|nested] only message in thread