From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ez3YG-0005IM-9R for mharc-qemu-trivial@gnu.org; Thu, 22 Mar 2018 12:58:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez3YD-0005GE-QR for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez3YC-0002Pv-W5 for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:58:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46256 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ez3Y0-0002AV-4L; Thu, 22 Mar 2018 12:58:40 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8369D40201A6; Thu, 22 Mar 2018 16:58:34 +0000 (UTC) Received: from [10.40.204.35] (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4E0084434; Thu, 22 Mar 2018 16:58:18 +0000 (UTC) To: Max Filippov Cc: qemu-devel , Peter Crosthwaite , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= , "Dr. David Alan Gilbert" , Paolo Bonzini , David Gibson , Kevin Wolf , Richard Henderson , qemu-arm@nongnu.org, Eric Blake , Jason Wang , Max Reitz , Fam Zheng , QEMU Trivial , Alexander Graf , qemu-ppc , Peter Maydell , Alberto Garcia , qemu-block@nongnu.org, Igor Mitsyanko , Yongbok Kim , "Michael S. Tsirkin" , Aurelien Jarno , Eduardo Habkost , Markus Armbruster References: <20180322161226.29796-1-lvivier@redhat.com> <20180322161226.29796-5-lvivier@redhat.com> From: Laurent Vivier Message-ID: <6fd26097-aa7e-38cf-0d9e-09d0d36bd88b@redhat.com> Date: Thu, 22 Mar 2018 17:58:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 22 Mar 2018 16:58:34 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 22 Mar 2018 16:58:34 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lvivier@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH 4/4] Remove unnecessary variables for function return value X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 16:58:54 -0000 On 22/03/2018 17:51, Max Filippov wrote: > On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote: >> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >> >> Signed-off-by: Laurent Vivier >> --- >> target/xtensa/core-dc232b/xtensa-modules.c | 56 ++++++---------------- >> target/xtensa/core-dc233c/xtensa-modules.c | 56 ++++++---------------- >> target/xtensa/core-de212/xtensa-modules.c | 48 +++++-------------- >> target/xtensa/core-fsf/xtensa-modules.c | 32 ++++--------- >> .../xtensa/core-sample_controller/xtensa-modules.c | 24 +++------- > > These files were autogenerated, fixing them doesn't make much sense. Good to know. They have been already updated by a couple of patches: 8f0a3716e4 Clean up includes d8e39b7062 Use #include "..." for our own headers, <...> for others Perhaps import_core.sh can be updated? Thanks, Laurent