From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ez3Z7-0005yJ-0Y for mharc-qemu-trivial@gnu.org; Thu, 22 Mar 2018 12:59:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez3Z1-0005tG-BX for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez3Yy-0003Al-7x for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:59:43 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35502 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ez3Ym-0002sc-R3; Thu, 22 Mar 2018 12:59:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 18414406E8DB; Thu, 22 Mar 2018 16:59:28 +0000 (UTC) Received: from [10.10.121.135] (ovpn-121-135.rdu2.redhat.com [10.10.121.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D7502166BAE; Thu, 22 Mar 2018 16:59:25 +0000 (UTC) To: Max Filippov , Laurent Vivier References: <20180322161226.29796-1-lvivier@redhat.com> <20180322161226.29796-5-lvivier@redhat.com> Cc: qemu-devel , Peter Crosthwaite , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= , "Dr. David Alan Gilbert" , Paolo Bonzini , David Gibson , Kevin Wolf , Richard Henderson , qemu-arm@nongnu.org, Jason Wang , Max Reitz , Fam Zheng , QEMU Trivial , Alexander Graf , qemu-ppc , Peter Maydell , Alberto Garcia , qemu-block@nongnu.org, Igor Mitsyanko , Yongbok Kim , "Michael S. Tsirkin" , Aurelien Jarno , Eduardo Habkost , Markus Armbruster From: Eric Blake Organization: Red Hat, Inc. Message-ID: <72681a04-d10d-3e88-0671-118a03466eca@redhat.com> Date: Thu, 22 Mar 2018 11:59:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 22 Mar 2018 16:59:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 22 Mar 2018 16:59:28 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'eblake@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH 4/4] Remove unnecessary variables for function return value X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 16:59:47 -0000 On 03/22/2018 11:51 AM, Max Filippov wrote: > On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote: >> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >> >> Signed-off-by: Laurent Vivier >> --- >> target/xtensa/core-dc232b/xtensa-modules.c | 56 ++++++---------------- >> target/xtensa/core-dc233c/xtensa-modules.c | 56 ++++++---------------- >> target/xtensa/core-de212/xtensa-modules.c | 48 +++++-------------- >> target/xtensa/core-fsf/xtensa-modules.c | 32 ++++--------- >> .../xtensa/core-sample_controller/xtensa-modules.c | 24 +++------- > > These files were autogenerated, fixing them doesn't make much sense. How frequently is the generator rerun? Is it something where we are likely to revert the change because it needs to be rerun soon? If so, then is it worth fixing the generator to output more concise code? Conversely, if they were generated up front, but likely to remain unchanged into the future, then fixing them (even though the fix differs from the generator) will mean they no longer show up as false positives in future runs of the Coccinelle script. I'm also fine removing the changes to these files as part of preparing the PULL request, if that's what you would prefer. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org