From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f80pI-0001z0-7H for mharc-qemu-trivial@gnu.org; Mon, 16 Apr 2018 05:53:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f80pF-0001xe-3B for qemu-trivial@nongnu.org; Mon, 16 Apr 2018 05:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f80pB-0004uJ-2I for qemu-trivial@nongnu.org; Mon, 16 Apr 2018 05:53:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59668 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f80p5-0004kU-CN; Mon, 16 Apr 2018 05:53:19 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC8BD722FE; Mon, 16 Apr 2018 09:53:18 +0000 (UTC) Received: from mapfelba-osx.local (unknown [10.35.206.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 988CF7C5C; Mon, 16 Apr 2018 09:53:17 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-trivial@nongnu.org, Thomas Huth Cc: qemu-devel@nongnu.org, Eduardo Habkost References: <20180415234307.28132-1-f4bug@amsat.org> <20180415234307.28132-42-f4bug@amsat.org> From: Marcel Apfelbaum Openpgp: preference=signencrypt Autocrypt: addr=marcel@redhat.com; prefer-encrypt=mutual; keydata= xsBNBFpwpFoBCAC66VT3ZMlr10I420na21Mdr6q/+v5XJ6w8QPOTFQMd4V4viNXT7rgJ8Qfv m4ViMaLoHBEmL6Kte4UNz3x28DUl91EcWpSRSMMGMa2oWj6Qv/9150byAByBYo2GijfIoayd NKyAZ+PnlsJ2uQgb1I0wLUZ5tDpMeZFkC2Wb8QC9fsv9N7gOA5kvT2Mea0XzNVWHowt9A0hv 8+2O1YrqhqW7HVoLiET3XCec81rRPk+SbewVJtNIFkzamHBVruk4xozWZuluM8DNE4u+wlVx NsI6gxoJV9DKthh0QDqPVy01FpBPk3fHkIdQZeo3eaTE9EHU+OW8iDTXIG1HRLzt6SovABEB AAHNJE1hcmNlbCBBcGZlbGJhdW0gPG1hcmNlbEByZWRoYXQuY29tPsLAeAQTAQIAIgUCWnCk WgIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQNtTA8M8v5G2awAf/eb5BhjgTEoc6 6En2oT2UnHvXvcGZlaMonfal9WDh/dgy3HmlV9nLdbc0xLEHywtIpthgXMRi+zN6tmOv6ddq I4HmhvXHWnqoxIoOqpkCSFsYI3eq/z8n80FE8wAudUA6IyS/riLfUUOfh3g90d3bnRYTHCGF ytFc9je4NmFvCJeIBJ9U/8QkmzZ5NXPP52HT0hSfIfOarxba2y91M05VMyAr38eskT0K2n0p O9nruETrUu+OfXRFlil+0TsVaKH5ZxREEO6OrFUFZc/CWvgaewrCDljckJB+xDib0eFaGb/A bhB8zVwJDyFgtvDfqHKfyx1BHskXxrRZdyjGTTAHAc7ATQRacKRaAQgAq5+6KAJvy6FTeHJU Y5G3fensizw6Zn+YJ2elPCFMVd9bivYBZnr9tdv2tJtEar/buk/azOUYxki2T3aEAok1IUXW yjCrwdwi8m8DAlvkZDDTA9i/cRJLd4otAB/TZWRrzT9oJN/odp4vpiwlu+0EkGCA1G/81Q0s f062diIxm4GCmrP6hSliz8vGXJPQwjJuMQrgQH0ZW3WVXTyRJUgKzeW0Eo2YaJSnwIOormAD pxuP5eHepg1+ph06XPkhujOW+/wD3qRSWbKmmemEP98w+lmsefDXGGTMzgkFaPooFfxo0tJe nVxSTZjWWhxmjCdi3oSvRVdJ/ey4XoTj1kWacwARAQABwsBfBBgBAgAJBQJacKRaAhsMAAoJ EDbUwPDPL+RtqH0H/34w4BflnhIxUpJYVdDQ1ypizk+UbmA9uI8ynMeeNqzSVZWihJ5syOGb ssc6HnPddNWnfRaSSdxNgxn7v0M5HmgBxoO4euxUGhG3o3T1N+PDRek7vP8FhREDDaslp9mF whJ/+/tjrAsMKSs+lVTAeuqQPo7BO9M7cugVPUEawq/OXTF6xnUq2oqVJtQ2wG0ZZNmuaN03 fEK8NjVpYnqnvvj3RyRqDCcAEcFKiZgXS0JXtYSGxQspDb0wY827IrF6QGh+2CttUkAfN02h qYRsKqlZ4/hwJdGFuy10kqgHjjV6/bfQNjSmSbQaGjDR9afGm5TnP3s6ghQFB2aOJohd3G4= Message-ID: <7924489e-fac9-b4aa-18a5-c2a0d7e0960d@redhat.com> Date: Mon, 16 Apr 2018 12:53:16 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180415234307.28132-42-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 16 Apr 2018 09:53:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 16 Apr 2018 09:53:18 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'marcel@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 09:53:31 -0000 On 16/04/2018 2:43, Philippe Mathieu-Daud=C3=A9 wrote: > All files using "qemu/units.h" definitions already include it directly, > we can now remove it from "qemu/cutils.h". >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/qemu/cutils.h | 1 - > hw/core/machine.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h > index 056e6629bb..cdb0f0db75 100644 > --- a/include/qemu/cutils.h > +++ b/include/qemu/cutils.h > @@ -2,7 +2,6 @@ > #define QEMU_CUTILS_H > =20 > #include "qemu/fprintf-fn.h" > -#include "qemu/units.h" > =20 > /** > * pstrcpy: > diff --git a/hw/core/machine.c b/hw/core/machine.c > index 2040177664..8f70c5ad94 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -19,7 +19,7 @@ > #include "sysemu/sysemu.h" > #include "sysemu/numa.h" > #include "qemu/error-report.h" > -#include "qemu/cutils.h" > +#include "qemu/units.h" > #include "sysemu/qtest.h" > =20 > static char *machine_get_accel(Object *obj, Error **errp) >=20 Reviewed-by: Marcel Apfelbaum Thanks, Marcel