* [PATCH] tests/docker: Fix typo in help message
@ 2021-01-19 5:21 Philippe Mathieu-Daudé
2021-01-19 11:22 ` Alex Bennée
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-19 5:21 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Fam Zheng, qemu-trivial,
Philippe Mathieu-Daudé, Philippe Mathieu-Daudé
To have the variable properly passed, we need to set it,
ie. NOUSER=1. Fix the message displayed by 'make docker'.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 0779dab5b96..bdc53ddfcf9 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -209,7 +209,7 @@ endif
@echo ' before running the command.'
@echo ' NETWORK=1 Enable virtual network interface with default backend.'
@echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
- @echo ' NOUSER Define to disable adding current user to containers passwd.'
+ @echo ' NOUSER=1 Define to disable adding current user to containers passwd.'
@echo ' NOCACHE=1 Ignore cache when build images.'
@echo ' EXECUTABLE=<path> Include executable in image.'
@echo ' EXTRA_FILES="<path> [... <path>]"'
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/docker: Fix typo in help message
2021-01-19 5:21 [PATCH] tests/docker: Fix typo in help message Philippe Mathieu-Daudé
@ 2021-01-19 11:22 ` Alex Bennée
0 siblings, 0 replies; 2+ messages in thread
From: Alex Bennée @ 2021-01-19 11:22 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Fam Zheng, qemu-trivial, Philippe Mathieu-Daudé
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> To have the variable properly passed, we need to set it,
> ie. NOUSER=1. Fix the message displayed by 'make docker'.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued to testing/next, thanks.
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 0779dab5b96..bdc53ddfcf9 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -209,7 +209,7 @@ endif
> @echo ' before running the command.'
> @echo ' NETWORK=1 Enable virtual network interface with default backend.'
> @echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
> - @echo ' NOUSER Define to disable adding current user to containers passwd.'
> + @echo ' NOUSER=1 Define to disable adding current user to containers passwd.'
> @echo ' NOCACHE=1 Ignore cache when build images.'
> @echo ' EXECUTABLE=<path> Include executable in image.'
> @echo ' EXTRA_FILES="<path> [... <path>]"'
--
Alex Bennée
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-19 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-19 5:21 [PATCH] tests/docker: Fix typo in help message Philippe Mathieu-Daudé
2021-01-19 11:22 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).