From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: lvivier@redhat.com, peter.maydell@linaro.org,
ehabkost@redhat.com, viktor.prutyanov@phystech.edu,
QEMU Trivial <qemu-trivial@nongnu.org>,
kraxel@redhat.com, marcel.apfelbaum@gmail.com,
alex.bennee@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] Clean up includes
Date: Thu, 11 Apr 2019 21:46:59 +0200 [thread overview]
Message-ID: <9585a1fc-fc7c-d3f4-06be-46d1a544a0ce@vivier.eu> (raw)
In-Reply-To: <8cd63797-76f6-9ba8-0113-13a4bf04e6ed@redhat.com>
On 21/03/2019 10:21, Thomas Huth wrote:
> On 13/03/2019 17.28, Markus Armbruster wrote:
>> Clean up includes so that osdep.h is included first and headers
>> which it implies are not included manually.
>>
>> This commit was created with scripts/clean-includes, with the changes
>> to the following files manually reverted:
>>
>> contrib/libvhost-user/libvhost-user-glib.h
>> contrib/libvhost-user/libvhost-user.c
>> contrib/libvhost-user/libvhost-user.h
>> linux-user/mips64/cpu_loop.c
>> linux-user/mips64/signal.c
>> linux-user/sparc64/cpu_loop.c
>> linux-user/sparc64/signal.c
>> linux-user/x86_64/cpu_loop.c
>> linux-user/x86_64/signal.c
>> slirp/src/*
>> target/s390x/gen-features.c
>> tests/migration/s390x/a-b-bios.c
>> tests/test-rcu-simpleq.c
>> tests/test-rcu-tailq.c
>> tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
>>
>> We're in the process of spinning out slirp/. tests/uefi-test-tools/
>> is guest software. The remaining reverts are the same as in commit
>> b7d89466dde.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> contrib/elf2dmp/main.c | 3 +--
>> contrib/elf2dmp/pdb.c | 3 +--
>> hw/display/ati.c | 1 +
>> hw/display/ati_2d.c | 1 +
>> hw/display/ati_dbg.c | 1 +
>> hw/display/ati_int.h | 1 -
>> include/hw/cpu/cluster.h | 1 -
>> tests/fp/platform.h | 1 -
>> tests/libqos/qgraph.h | 4 ----
>> tests/qos-test.c | 2 +-
>> 10 files changed, 6 insertions(+), 12 deletions(-)
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2019-04-11 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190313162812.8885-1-armbru@redhat.com>
2019-03-21 9:21 ` [Qemu-trivial] [PATCH] Clean up includes Thomas Huth
2019-04-11 19:46 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9585a1fc-fc7c-d3f4-06be-46d1a544a0ce@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=viktor.prutyanov@phystech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).