Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c

[Thomas Huth]

On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  authz/listfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/authz/listfile.c b/authz/listfile.c
> index d457976..03eaf46 100644
> --- a/authz/listfile.c
> +++ b/authz/listfile.c
> @@ -238,7 +238,7 @@ qauthz_list_file_init(Object *obj)
>  
>      authz->file_watch = -1;
>  #ifdef CONFIG_INOTIFY1
> -    authz->refresh = TRUE;
> +    authz->refresh = true;
>  #endif
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c

[Thomas Huth]

On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/libqos/pci-pc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c
> index 4ab16fa..407d8af 100644
> --- a/tests/libqos/pci-pc.c
> +++ b/tests/libqos/pci-pc.c
> @@ -125,7 +125,7 @@ void qpci_init_pc(QPCIBusPC *qpci, QTestState *qts, QGuestAllocator *alloc)
>      assert(qts);
>  
>      /* tests can use pci-bus */
> -    qpci->bus.has_buggy_msi = FALSE;
> +    qpci->bus.has_buggy_msi = false;
>  
>      qpci->bus.pio_readb = qpci_pc_pio_readb;
>      qpci->bus.pio_readw = qpci_pc_pio_readw;

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c

[Thomas Huth]

On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/libqos/pci-spapr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/libqos/pci-spapr.c b/tests/libqos/pci-spapr.c
> index 6925925..58ba27a 100644
> --- a/tests/libqos/pci-spapr.c
> +++ b/tests/libqos/pci-spapr.c
> @@ -156,7 +156,7 @@ void qpci_init_spapr(QPCIBusSPAPR *qpci, QTestState *qts,
>      assert(qts);
>  
>      /* tests cannot use spapr, needs to be fixed first */
> -    qpci->bus.has_buggy_msi = TRUE;
> +    qpci->bus.has_buggy_msi = true;
>  
>      qpci->alloc = alloc;

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

[Thomas Huth]

On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> ---
>  hw/tpm/tpm_tis.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index fd183e8..c1eb094 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -611,7 +611,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>              while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) &&
>                      locty > s->active_locty) ||
>                      !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {
> -                bool higher_seize = FALSE;
> +                bool higher_seize = false;
>  
>                  /* already a pending SEIZE ? */
>                  if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) {
> @@ -621,7 +621,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>                  /* check for ongoing seize by a higher locality */
>                  for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) {
>                      if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) {
> -                        higher_seize = TRUE;
> +                        higher_seize = true;
>                          break;
>                      }
>                  }
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

[Stefan Berger]

On 3/24/19 3:41 PM, Thomas Huth wrote:
> On 23/03/2019 15.26, Jafar Abdi wrote:
>> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
>>
>> FALSE and TRUE (with capital letters) are the constants defined by glib for
>> being used with the "gboolean" type of glib. But some parts of the code also use
>> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
>>
>> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
>> ---
>>   hw/tpm/tpm_tis.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
>> index fd183e8..c1eb094 100644
>> --- a/hw/tpm/tpm_tis.c
>> +++ b/hw/tpm/tpm_tis.c
>> @@ -611,7 +611,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>>               while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) &&
>>                       locty > s->active_locty) ||
>>                       !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {
>> -                bool higher_seize = FALSE;
>> +                bool higher_seize = false;
>>   
>>                   /* already a pending SEIZE ? */
>>                   if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) {
>> @@ -621,7 +621,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>>                   /* check for ongoing seize by a higher locality */
>>                   for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) {
>>                       if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) {
>> -                        higher_seize = TRUE;
>> +                        higher_seize = true;
>>                           break;
>>                       }
>>                   }
>>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>

Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

[Daniel P. Berrangé]

ping, again, for either qemu-trivial or TPM maintainers to take this
patch.

The other three in this series are merged, but this TPM patch is
still pending.

On Tue, Mar 26, 2019 at 09:55:24AM -0400, Stefan Berger wrote:
> On 3/24/19 3:41 PM, Thomas Huth wrote:
> > On 23/03/2019 15.26, Jafar Abdi wrote:
> > > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> > > 
> > > FALSE and TRUE (with capital letters) are the constants defined by glib for
> > > being used with the "gboolean" type of glib. But some parts of the code also use
> > > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> > > 
> > > Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> > > ---
> > >   hw/tpm/tpm_tis.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> > > index fd183e8..c1eb094 100644
> > > --- a/hw/tpm/tpm_tis.c
> > > +++ b/hw/tpm/tpm_tis.c
> > > @@ -611,7 +611,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
> > >               while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) &&
> > >                       locty > s->active_locty) ||
> > >                       !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {
> > > -                bool higher_seize = FALSE;
> > > +                bool higher_seize = false;
> > >                   /* already a pending SEIZE ? */
> > >                   if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) {
> > > @@ -621,7 +621,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
> > >                   /* check for ongoing seize by a higher locality */
> > >                   for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) {
> > >                       if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) {
> > > -                        higher_seize = TRUE;
> > > +                        higher_seize = true;
> > >                           break;
> > >                       }
> > >                   }
> > > 
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> > 
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

[Stefan Berger]

On 5/7/20 7:52 AM, Daniel P. Berrangé wrote:
> ping, again, for either qemu-trivial or TPM maintainers to take this
> patch.
>
> The other three in this series are merged, but this TPM patch is
> still pending.


I'll send a PR with it tonight.

Re: [Qemu-trivial] [PATCH V2 0/4] fix usage of bool

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).

CCing qemu-trivial

> Jafar Abdi (4):
>   authz: fix usage of bool in listfile.c
>   tests/libqos: fix usage of bool in pci-pc.c
>   tests/libqos: fix usage of bool in pci-spapr.c
>   hw/tpm: fix usage of bool in tpm-tis.c
> 
>  authz/listfile.c         | 2 +-
>  hw/tpm/tpm_tis.c         | 4 ++--
>  tests/libqos/pci-pc.c    | 2 +-
>  tests/libqos/pci-spapr.c | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> -- 
> 2.7.4
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 0/4] fix usage of bool

[Daniel P. Berrangé]

On Tue, Mar 26, 2019 at 08:18:14AM +0000, Stefan Hajnoczi wrote:
> On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote:
> > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> > 
> > FALSE and TRUE (with capital letters) are the constants defined by glib for
> > being used with the "gboolean" type of glib. But some parts of the code also use
> > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> CCing qemu-trivial

Ping qemu-trivial - this was seems to have been missed, though
patches 2 & 3 got merged via ppc tree meanwhile. The other two
are still valid.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|