From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 09/11] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf
Date: Fri, 22 Jun 2018 10:36:23 +0200 [thread overview]
Message-ID: <9eba4426-6870-29a4-cb4b-63af49350fe9@redhat.com> (raw)
In-Reply-To: <20180621180224.8312-10-f4bug@amsat.org>
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/arm/stellaris.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
> index a8f1f6a912..d06e366402 100644
> --- a/hw/arm/stellaris.c
> +++ b/hw/arm/stellaris.c
> @@ -560,7 +560,7 @@ static void ssys_write(void *opaque, hwaddr offset,
> case 0x040: /* SRCR0 */
> case 0x044: /* SRCR1 */
> case 0x048: /* SRCR2 */
> - fprintf(stderr, "Peripheral reset not implemented\n");
> + qemu_log_mask(LOG_UNIMP, "Peripheral reset not implemented\n");
> break;
> case 0x054: /* IMC */
> s->int_mask = value & 0x7f;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-06-22 8:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:02 [Qemu-trivial] [PATCH 00/11] hw/arm: use qemu_log_mask instead of fprintf Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 01/11] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-22 8:04 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-22 13:19 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 02/11] hw/input/tsc2005: " Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 03/11] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-22 8:11 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 04/11] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2018-06-22 8:24 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-22 13:23 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 05/11] hw/ssi/omap_spi: " Philippe Mathieu-Daudé
2018-06-21 18:04 ` [Qemu-trivial] [Qemu-devel] " Alistair Francis
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-22 8:26 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 07/11] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2018-06-22 8:29 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-22 8:34 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-22 13:23 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 09/11] hw/arm/stellaris: Use qemu_log_mask(UNIMP) " Philippe Mathieu-Daudé
2018-06-22 8:36 ` Thomas Huth [this message]
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 10/11] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error Philippe Mathieu-Daudé
2018-06-22 8:43 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2018-06-22 13:24 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-trivial] [PATCH 11/11] hw/net/smc91c111: " Philippe Mathieu-Daudé
2018-06-22 8:43 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eba4426-6870-29a4-cb4b-63af49350fe9@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).