* Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations
[not found] ` <20250115232247.30364-2-philmd@linaro.org>
@ 2025-01-17 8:52 ` Thomas Huth
2025-01-30 9:59 ` Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2025-01-17 8:52 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, QEMU Trivial
Cc: Jason Wang, Hanna Reitz, Dmitry Fleytman, qemu-block, Fam Zheng,
Paolo Bonzini, Michael S. Tsirkin, Zhao Liu, Yanan Wang,
Kevin Wolf, Eduardo Habkost, Richard Henderson, Marcel Apfelbaum,
Gerd Hoffmann, John Snow
On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote:
> We removed the implementations in commit 46a2bd52571
> ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
> but forgot to remove the declarations. Do it now.
>
> Fixes: 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/i386/pc.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index a558705cb9a..103b54301f8 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -302,9 +302,6 @@ extern const size_t pc_compat_2_5_len;
> extern GlobalProperty pc_compat_2_4[];
> extern const size_t pc_compat_2_4_len;
>
> -extern GlobalProperty pc_compat_2_3[];
> -extern const size_t pc_compat_2_3_len;
> -
> #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
> static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \
> { \
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations
2025-01-17 8:52 ` [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations Thomas Huth
@ 2025-01-30 9:59 ` Michael Tokarev
2025-01-30 10:27 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2025-01-30 9:59 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel,
QEMU Trivial
Cc: qemu-block
17.01.2025 11:52, Thomas Huth wrote:
> On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote:
>> We removed the implementations in commit 46a2bd52571
>> ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
>> but forgot to remove the declarations. Do it now.
>>
>> Fixes: 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thomas, such pick-ups from larger series may not be a good idea
for qemu-trivial in general. But this one looks okay'ish since
the series is about 2.4 and 2.5 machines :)
Philippe, are you okay with merging this one through qemu-trivial?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations
2025-01-30 9:59 ` Michael Tokarev
@ 2025-01-30 10:27 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-01-30 10:27 UTC (permalink / raw)
To: Michael Tokarev, Thomas Huth, qemu-devel, QEMU Trivial; +Cc: qemu-block
On 30/1/25 10:59, Michael Tokarev wrote:
> 17.01.2025 11:52, Thomas Huth wrote:
>> On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote:
>>> We removed the implementations in commit 46a2bd52571
>>> ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
>>> but forgot to remove the declarations. Do it now.
>>>
>>> Fixes: 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3
>>> machine")
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thomas, such pick-ups from larger series may not be a good idea
> for qemu-trivial in general. But this one looks okay'ish since
> the series is about 2.4 and 2.5 machines :)
>
> Philippe, are you okay with merging this one through qemu-trivial?
Sure! Even appreciated :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-30 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250115232247.30364-1-philmd@linaro.org>
[not found] ` <20250115232247.30364-2-philmd@linaro.org>
2025-01-17 8:52 ` [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations Thomas Huth
2025-01-30 9:59 ` Michael Tokarev
2025-01-30 10:27 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).