From: Blue Swirl <blauwirbel@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Make epoll_create1 test work around SPARC glibc bug
Date: Wed, 20 Apr 2011 19:31:22 +0300 [thread overview]
Message-ID: <BANLkTi=AFwiHd_cWV62buQv3=0U9wQDX3w@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimCYjx1JjT1Wb-Rt19TPG8pKfrGxA@mail.gmail.com>
On Wed, Apr 20, 2011 at 9:53 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 April 2011 21:36, Blue Swirl <blauwirbel@gmail.com> wrote:
>> Sorry, I just picked a define without much thought. A more specific
>> one would be flags parameter of epoll_create1(), like EPOLL_CLOEXEC or
>> EPOLL_NONBLOCK. We don't use them now since the target system call
>> argument is passed untranslated to host, but that is actually not
>> correct, since the bit definitions could be different. So checking for
>> one of those should be OK.
>
> Unfortunately the header file on the system in question defines
> both EPOLL_CLOEXEC and EPOLL_NONBLOCK even though it doesn't
> prototype epoll_create1(). So this idea won't work.
> The bug we are effectively trying to work around is the one fixed
> by this libc patch:
> http://sourceware.org/ml/libc-alpha/2010-08/msg00128.html
>
> The only problem with the header is that it doesn't declare the
> function, so the only way to detect it is to do something that
> will fail if the function isn't declared, like compiling -Werror.
This also fails without -Werror:
#include <sys/epoll.h>
int main(void)
{
epoll_create1;
return 0;
}
prev parent reply other threads:[~2011-04-20 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 8:57 [Qemu-trivial] [PATCH] configure: Make epoll_create1 test work around SPARC glibc bug Peter Maydell
2011-04-19 19:37 ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2011-04-19 19:48 ` Peter Maydell
2011-04-19 19:59 ` Blue Swirl
2011-04-19 20:16 ` Peter Maydell
2011-04-19 20:36 ` Blue Swirl
2011-04-20 6:53 ` Peter Maydell
2011-04-20 16:31 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=AFwiHd_cWV62buQv3=0U9wQDX3w@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).