From: Matthew Fernandez <matthew.fernandez@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-trivial@nongnu.org, Stefan Weil <weil@mail.berlios.de>,
qemu-devel Developers <qemu-devel@nongnu.org>,
Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] Fix comment typos in hw/armv7m.c
Date: Thu, 23 Jun 2011 20:35:26 +1000 [thread overview]
Message-ID: <BANLkTimJgByZ3TpNE9CFAC+QB4xNmQoE7Q@mail.gmail.com> (raw)
In-Reply-To: <57FD980B-E6A3-4E1A-A83B-062B9954DB5C@web.de>
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
On 23 June 2011 20:22, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 23.06.2011 um 02:59 schrieb Matthew Fernandez:
>
>
> Fix a couple of typos in comments.
>>
>> Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>
>> ----
>> This patch doesn't touch any code and should (hopefully) not be
>> controversial. There doesn't seem to be a maintainer for this file,
>> but changes are trivial.
>>
>>
>> diff --git a/hw/armv7m.c b/hw/armv7m.c
>> index 72d010a..83f3393 100644
>> --- a/hw/armv7m.c
>> +++ b/hw/armv7m.c
>> @@ -4,7 +4,7 @@
>> * Copyright (c) 2006-2007 CodeSourcery.
>> * Written by Paul Brook
>> *
>> - * This code is licenced under the GPL.
>> + * This code is licensed under the GPL.
>>
>
> Nack. Licence is British English, license American English. It's not wrong.
Licence is the noun in British English, while license in the noun in
American English. License is the correct verb in both. Nevertheless, I don't
think this is worth debating. If there's dissent I'm happy to drop the first
part of the patch.
>
>
> */
>>
>> #include "sysbus.h"
>> @@ -14,7 +14,7 @@
>>
>> /* Bitbanded IO. Each word corresponds to a single bit. */
>>
>> -/* Get the byte address of the real memory for a bitband acess. */
>> +/* Get the byte address of the real memory for a bitband access. */
>>
>
> This one's okay.
>
> Andreas
>
>
> static inline uint32_t bitband_addr(void * opaque, uint32_t addr)
>> {
>> uint32_t res;
>>
>>
>
[-- Attachment #2: Type: text/html, Size: 2639 bytes --]
next prev parent reply other threads:[~2011-06-23 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 0:59 [Qemu-trivial] [PATCH trivial] Fix comment typos in hw/armv7m.c Matthew Fernandez
2011-06-23 5:22 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-06-23 8:08 ` Matthew Fernandez
2011-06-23 14:42 ` Stefan Weil
2011-06-23 10:22 ` Andreas Färber
2011-06-23 10:35 ` Matthew Fernandez [this message]
2011-06-23 10:55 ` Andreas Färber
2011-06-23 13:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimJgByZ3TpNE9CFAC+QB4xNmQoE7Q@mail.gmail.com \
--to=matthew.fernandez@gmail.com \
--cc=andreas.faerber@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).