qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal
@ 2012-04-07 15:58 Stefan Weil
  2012-04-07 15:58 ` [Qemu-trivial] [PATCH (rebased) 2/2] Add QEMU_NORETURN to function cpu_io_recompile Stefan Weil
  2012-04-07 20:17 ` [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Blue Swirl
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2012-04-07 15:58 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Blue Swirl, Stefan Weil

cpu_resume_from_signal terminates by calling longjmp.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 exec-all.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/exec-all.h b/exec-all.h
index a6d6519..4758d88 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -86,7 +86,7 @@ int cpu_gen_code(CPUArchState *env, struct TranslationBlock *tb,
                  int *gen_code_size_ptr);
 int cpu_restore_state(struct TranslationBlock *tb,
                       CPUArchState *env, uintptr_t searched_pc);
-void cpu_resume_from_signal(CPUArchState *env1, void *puc);
+void QEMU_NORETURN cpu_resume_from_signal(CPUArchState *env1, void *puc);
 void cpu_io_recompile(CPUArchState *env, void *retaddr);
 TranslationBlock *tb_gen_code(CPUArchState *env, 
                               target_ulong pc, target_ulong cs_base, int flags,
-- 
1.7.9



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Qemu-trivial] [PATCH (rebased) 2/2] Add QEMU_NORETURN to function cpu_io_recompile
  2012-04-07 15:58 [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Stefan Weil
@ 2012-04-07 15:58 ` Stefan Weil
  2012-04-07 20:17 ` [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Blue Swirl
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2012-04-07 15:58 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Blue Swirl, Stefan Weil

cpu_io_recompile terminates by calling either cpu_abort or
cpu_resume_from_signal which both never return.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 exec-all.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/exec-all.h b/exec-all.h
index 4758d88..fa7bdfe 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -87,7 +87,7 @@ int cpu_gen_code(CPUArchState *env, struct TranslationBlock *tb,
 int cpu_restore_state(struct TranslationBlock *tb,
                       CPUArchState *env, uintptr_t searched_pc);
 void QEMU_NORETURN cpu_resume_from_signal(CPUArchState *env1, void *puc);
-void cpu_io_recompile(CPUArchState *env, void *retaddr);
+void QEMU_NORETURN cpu_io_recompile(CPUArchState *env, void *retaddr);
 TranslationBlock *tb_gen_code(CPUArchState *env, 
                               target_ulong pc, target_ulong cs_base, int flags,
                               int cflags);
-- 
1.7.9



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal
  2012-04-07 15:58 [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Stefan Weil
  2012-04-07 15:58 ` [Qemu-trivial] [PATCH (rebased) 2/2] Add QEMU_NORETURN to function cpu_io_recompile Stefan Weil
@ 2012-04-07 20:17 ` Blue Swirl
  1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2012-04-07 20:17 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, qemu-devel

Thanks, applied both.

On Sat, Apr 7, 2012 at 15:58, Stefan Weil <sw@weilnetz.de> wrote:
> cpu_resume_from_signal terminates by calling longjmp.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  exec-all.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/exec-all.h b/exec-all.h
> index a6d6519..4758d88 100644
> --- a/exec-all.h
> +++ b/exec-all.h
> @@ -86,7 +86,7 @@ int cpu_gen_code(CPUArchState *env, struct TranslationBlock *tb,
>                  int *gen_code_size_ptr);
>  int cpu_restore_state(struct TranslationBlock *tb,
>                       CPUArchState *env, uintptr_t searched_pc);
> -void cpu_resume_from_signal(CPUArchState *env1, void *puc);
> +void QEMU_NORETURN cpu_resume_from_signal(CPUArchState *env1, void *puc);
>  void cpu_io_recompile(CPUArchState *env, void *retaddr);
>  TranslationBlock *tb_gen_code(CPUArchState *env,
>                               target_ulong pc, target_ulong cs_base, int flags,
> --
> 1.7.9
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-07 20:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-07 15:58 [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Stefan Weil
2012-04-07 15:58 ` [Qemu-trivial] [PATCH (rebased) 2/2] Add QEMU_NORETURN to function cpu_io_recompile Stefan Weil
2012-04-07 20:17 ` [Qemu-trivial] [PATCH (rebased) 1/2] Add QEMU_NORETURN to function cpu_resume_from_signal Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).