From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new packed structures
Date: Wed, 18 Jul 2012 17:33:58 +0100 [thread overview]
Message-ID: <CAFEAcA-Cg7HOU3okDFUOdD9iG3z4gYKQovoNoFRibVV-1_E3Mw@mail.gmail.com> (raw)
In-Reply-To: <1342627957-31682-1-git-send-email-sw@weilnetz.de>
On 18 July 2012 17:12, Stefan Weil <sw@weilnetz.de> wrote:
> Since commit 541dc0d47f10973c241e9955afc2aefc96adec51,
> some new packed structures were added without using QEMU_PACKED.
>
> QEMU_PACKED is needed for compilations with MinGW.
> For other platforms nothing changes.
>
> The code was fixed using this command:
>
> git grep -la '__attribute__ ((packed))'|xargs perl -pi -e 's/__attribute__ \(\(packed\)\)/QEMU_PACKED/'
There's one in tcg/tcg.c as well, which you missed because
it doesn't have a space between the "__attribute__" and
"((packed))".
(There are also some in some of the tcg-target.c files,
but those are cases of the packed attribute being applied
to individual struct members rather than a whole struct, so
I'm not entirely sure what we should do with those.)
-- PMM
next prev parent reply other threads:[~2012-07-18 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 16:12 [Qemu-trivial] [PATCH] Use macro QEMU_PACKED for new packed structures Stefan Weil
2012-07-18 16:33 ` Peter Maydell [this message]
2012-07-18 16:42 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2012-07-18 16:51 ` Peter Maydell
2012-07-21 9:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-Cg7HOU3okDFUOdD9iG3z4gYKQovoNoFRibVV-1_E3Mw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).