From: Peter Maydell <peter.maydell@linaro.org>
To: Ed Maste <emaste@freebsd.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning
Date: Tue, 5 Apr 2016 18:13:12 +0100 [thread overview]
Message-ID: <CAFEAcA815OmtxmxafnGN=5B9gHDmz4r5YC6zhkFN9DbywUDJeQ@mail.gmail.com> (raw)
In-Reply-To: <1459867593-72017-1-git-send-email-emaste@freebsd.org>
On 5 April 2016 at 15:46, Ed Maste <emaste@freebsd.org> wrote:
> This is the same change as b55266b5 in linux-user.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> bsd-user/uaccess.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c
> index b7b3a06..91e2067 100644
> --- a/bsd-user/uaccess.c
> +++ b/bsd-user/uaccess.c
> @@ -51,7 +51,7 @@ abi_long target_strlen(abi_ulong guest_addr1)
> ptr = lock_user(VERIFY_READ, guest_addr, max_len, 1);
> if (!ptr)
> return -TARGET_EFAULT;
> - len = qemu_strnlen((char *)ptr, max_len);
> + len = qemu_strnlen((const char *)ptr, max_len);
> unlock_user(ptr, guest_addr, 0);
> guest_addr += len;
> /* we don't allow wrapping or integer overflow */
> --
> 2.4.6
Applied to master, thanks.
-- PMM
prev parent reply other threads:[~2016-04-05 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 14:46 [Qemu-trivial] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning Ed Maste
2016-04-05 14:54 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2016-04-05 15:26 ` Ed Maste
2016-04-05 17:13 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA815OmtxmxafnGN=5B9gHDmz4r5YC6zhkFN9DbywUDJeQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=emaste@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).